From: Florian Westphal <fw@strlen.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: icmp_route_lookup returns wrong source address information
Date: Fri, 22 Jul 2011 16:15:31 +0200 [thread overview]
Message-ID: <20110722141531.GA12328@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <20110722.062302.350752564450519025.davem@davemloft.net>
David Miller <davem@davemloft.net> wrote:
> From: Florian Westphal <fw@strlen.de>
> Date: Wed, 20 Jul 2011 21:22:58 +0200
>
> > Problem is that xfrm_decode_session_reverse() may rebuild fl4 from scratch.
> >
> > In my setup, "goto relookup_failed" will be hit a bit later on, and fl4->saddr will
> > be set to iph->daddr...
>
> Indeed, we can't use this new fl4 until we commit to using 'rt2'.
>
> Please give this patch a try:
>
> --------------------
> icmp: Fix regression in nexthop resolution during replies.
>
> icmp_route_lookup() uses the wrong flow parameters if the reverse
> session route lookup isn't used.
>
> So do not commit to the re-decoded flow until we actually make a
> final decision to use a real route saved in 'rt2'.
Thanks, traceroute shows the expected 1st hop again
with your patch applied.
next prev parent reply other threads:[~2011-07-22 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 19:22 icmp_route_lookup returns wrong source address information Florian Westphal
2011-07-22 7:59 ` David Miller
2011-07-22 13:23 ` David Miller
2011-07-22 14:15 ` Florian Westphal [this message]
2011-07-22 14:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722141531.GA12328@Chamillionaire.breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox