From: Herbert Xu <herbert@gondor.apana.org.au>
To: Shirley Ma <mashirle@us.ibm.com>
Cc: davem@davemloft.net, mst@redhat.com, netdev@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] skbuff: clear tx zero-copy flag
Date: Mon, 25 Jul 2011 08:42:00 +0800 [thread overview]
Message-ID: <20110725004200.GA25794@gondor.apana.org.au> (raw)
In-Reply-To: <1310195566.25391.6.camel@localhost.localdomain>
Shirley Ma <mashirle@us.ibm.com> wrote:
>
> This patch clears tx zero-copy flag as needed.
>
> Sign-off-by: Shirley Ma <xma@us.ibm.com>
I think we also need to copy and clear this flag on the splice
read path as that takes a direct page reference.
I hope there isn't any other path that does this.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2011-07-25 0:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 7:12 [PATCH net-next] skbuff: clear tx zero-copy flag Shirley Ma
2011-07-09 9:55 ` David Miller
2011-07-25 0:42 ` Herbert Xu [this message]
2011-07-25 8:07 ` Michael S. Tsirkin
2011-07-25 8:40 ` Herbert Xu
2011-07-25 9:44 ` Michael S. Tsirkin
2011-07-25 9:57 ` Herbert Xu
2011-07-25 10:02 ` David Miller
2011-07-25 10:53 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725004200.GA25794@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mashirle@us.ibm.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).