From: Anton Blanchard <anton@samba.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: casey@schaufler-ca.com, mjt@tls.msk.ru, davem@davemloft.net,
netdev@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCH] net: Fix security_socket_sendmsg() bypass problem.
Date: Tue, 26 Jul 2011 19:55:57 +1000 [thread overview]
Message-ID: <20110726195557.5abcf96d@kryten> (raw)
In-Reply-To: <201107260143.CGH18263.FOOSVMOQFJFLHt@I-love.SAKURA.ne.jp>
Hi,
> I fear it too. Unless many dozens (maybe some hundreds) of packets
> are sent by sendmmsg(), msg11504.html might show better performance
> than msg11510.html . But I don't have a machine to benchmark.
Not sure what happened to your email but the gains are evident at
just 2 packets.
I can help with testing - the commit included a microbenchmark for
the purposes of analysing its performance.
Anton
--
net: Add sendmmsg socket system call
This patch adds a multiple message send syscall and is the send
version of the existing recvmmsg syscall. This is heavily
based on the patch by Arnaldo that added recvmmsg.
I wrote a microbenchmark to test the performance gains of using
this new syscall:
http://ozlabs.org/~anton/junkcode/sendmmsg_test.c
The test was run on a ppc64 box with a 10 Gbit network card. The
benchmark can send both UDP and RAW ethernet packets.
64B UDP
batch pkts/sec
1 804570
2 872800 (+ 8 %)
4 916556 (+14 %)
8 939712 (+17 %)
16 952688 (+18 %)
32 956448 (+19 %)
64 964800 (+20 %)
64B raw socket
batch pkts/sec
1 1201449
2 1350028 (+12 %)
4 1461416 (+22 %)
8 1513080 (+26 %)
16 1541216 (+28 %)
32 1553440 (+29 %)
64 1557888 (+30 %)
We see a 20% improvement in throughput on UDP send and 30%
on raw socket send.
[ Add sparc syscall entries. -DaveM ]
next prev parent reply other threads:[~2011-07-26 9:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201107110304.p6B34422036886@www262.sakura.ne.jp>
[not found] ` <201107191754.22391.paul.moore@hp.com>
[not found] ` <201107200142.p6K1gKYg077046@www262.sakura.ne.jp>
[not found] ` <201107211721.14511.paul.moore@hp.com>
2011-07-22 11:41 ` Question regarding sendmmsg() Tetsuo Handa
2011-07-22 12:27 ` Tetsuo Handa
2011-07-22 15:12 ` [PATCH] net: Fix security_socket_sendmsg() bypass problem Tetsuo Handa
2011-07-22 15:22 ` David Miller
2011-07-22 17:42 ` Tetsuo Handa
2011-07-22 18:31 ` Tetsuo Handa
2011-07-23 5:20 ` Tetsuo Handa
2011-07-23 7:04 ` Michael Tokarev
2011-07-23 10:39 ` Tetsuo Handa
2011-07-25 12:20 ` Anton Blanchard
2011-07-25 13:15 ` Tetsuo Handa
2011-07-25 15:44 ` Casey Schaufler
2011-07-25 16:43 ` Tetsuo Handa
2011-07-25 17:00 ` Casey Schaufler
2011-07-26 9:55 ` Anton Blanchard [this message]
2011-07-26 11:21 ` Tetsuo Handa
2011-07-26 13:58 ` Eric Paris
2011-07-28 3:36 ` Tetsuo Handa
2011-08-02 6:07 ` David Miller
2011-08-02 9:28 ` Tetsuo Handa
2011-08-02 11:18 ` David Miller
2011-08-02 11:26 ` David Miller
2011-08-02 11:52 ` Tetsuo Handa
2011-08-02 12:01 ` David Miller
2011-08-02 13:11 ` Tetsuo Handa
2011-08-03 3:25 ` Tetsuo Handa
2011-08-03 3:38 ` David Miller
2011-08-03 3:47 ` Anton Blanchard
2011-08-03 12:20 ` Tetsuo Handa
2011-08-03 13:29 ` Anton Blanchard
2011-08-03 13:37 ` Eduard Sinelnikov
2011-08-03 21:50 ` Tetsuo Handa
2011-08-04 12:56 ` Anton Blanchard
2011-08-03 13:54 ` Anton Blanchard
2011-07-26 20:30 ` Question regarding sendmmsg() Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726195557.5abcf96d@kryten \
--to=anton@samba.org \
--cc=casey@schaufler-ca.com \
--cc=davem@davemloft.net \
--cc=linux-security-module@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).