From: David Miller <davem@davemloft.net>
To: herbert@gondor.hengli.com.au
Cc: netdev@vger.kernel.org
Subject: Re: gro: Only reset frag0 when skb can be pulled
Date: Wed, 27 Jul 2011 06:17:19 -0700 (PDT) [thread overview]
Message-ID: <20110727.061719.1278203020782685803.davem@davemloft.net> (raw)
In-Reply-To: <20110727131008.GA28825@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.hengli.com.au>
Date: Wed, 27 Jul 2011 21:10:08 +0800
> gro: Only reset frag0 when skb can be pulled
>
> Currently skb_gro_header_slow unconditionally resets frag0 and
> frag0_len. However, when we can't pull on the skb this leaves
> the GRO fields in an inconsistent state.
>
> This patch fixes this by only resetting those fields after the
> pskb_may_pull test.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks.
I'll queue this up for -stable too.
prev parent reply other threads:[~2011-07-27 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 13:10 gro: Only reset frag0 when skb can be pulled Herbert Xu
2011-07-27 13:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727.061719.1278203020782685803.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).