From: David Miller <davem@davemloft.net>
To: gregory.v.rose@intel.com
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com,
jeffrey.t.kirsher@intel.com
Subject: Re: [RFC net-next PATCH 2/4] ixgbe: Reconfigure SR-IOV Init
Date: Wed, 27 Jul 2011 22:26:53 -0700 (PDT) [thread overview]
Message-ID: <20110727.222653.1937782529626247279.davem@davemloft.net> (raw)
In-Reply-To: <20110727221754.8435.99712.stgit@gitlad.jf.intel.com>
From: Greg Rose <gregory.v.rose@intel.com>
Date: Wed, 27 Jul 2011 15:17:54 -0700
> + int i;
> + for (i = 0; i < adapter->num_vfs; i++) {
> + if (adapter->vfinfo[i].vfdev->dev_flags &
> + PCI_DEV_FLAGS_ASSIGNED) {
> + return true;
> + }
> + }
Bad formatting and indentation, please fix this.
> + pvfdev = pci_get_device(IXGBE_INTEL_VENDOR_ID, device_id, NULL);
> + while (pvfdev) {
> + if (pvfdev->devfn == thisvf_devfn)
> + break;
> + pvfdev = pci_get_device(IXGBE_INTEL_VENDOR_ID,
> + device_id, pvfdev);
> + }
> + if (pvfdev)
> + adapter->vfinfo[vfn].vfdev = pvfdev;
pci_get_*() grabs a reference to any non-NULL pci device object
returned, where does this reference get released? I scanned
all uses of x.vfdev and x->vfdev and could not find the necessary
release.
next prev parent reply other threads:[~2011-07-28 5:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 22:17 [RFC net-next PATCH 0/4] Add new settings for ethtool Greg Rose
2011-07-27 22:17 ` [RFC net-next PATCH 1/4] pci: Add flag indicating device has been assigned by KVM Greg Rose
2011-07-28 15:11 ` Ian Campbell
2011-07-28 15:58 ` Rose, Gregory V
2011-07-28 16:27 ` Ian Campbell
2011-07-28 16:42 ` Rose, Gregory V
2011-07-29 16:54 ` Konrad Rzeszutek Wilk
2011-07-30 4:00 ` Jeff Kirsher
2011-07-29 16:51 ` Jesse Barnes
2011-07-29 16:54 ` Rose, Gregory V
2011-07-27 22:17 ` [RFC net-next PATCH 2/4] ixgbe: Reconfigure SR-IOV Init Greg Rose
2011-07-28 5:26 ` David Miller [this message]
2011-07-28 15:44 ` Rose, Gregory V
2011-07-27 22:17 ` [RFC net-next PATCH 3/4] ethtool: Add new set commands Greg Rose
2011-07-28 5:27 ` David Miller
2011-07-28 15:51 ` Rose, Gregory V
2011-07-28 16:14 ` David Miller
2011-07-28 16:21 ` Rose, Gregory V
2011-07-28 21:14 ` Ben Hutchings
2011-07-28 21:16 ` Rose, Gregory V
[not found] ` <539DF151-E442-4375-8777-19676B95059B@qlogic.com>
2011-07-28 20:38 ` Rose, Gregory V
2011-07-28 22:01 ` Anirban Chakraborty
2011-07-28 22:04 ` Rose, Gregory V
2011-07-28 21:20 ` Ben Hutchings
2011-07-28 21:34 ` Rose, Gregory V
2011-07-28 22:04 ` Ben Hutchings
2011-07-28 22:25 ` Rose, Gregory V
2011-07-27 22:18 ` [RFC net-next PATCH 4/4] ixgbe: Add support for new ethtool settings Greg Rose
2011-07-28 11:54 ` Michał Mirosław
2011-07-28 15:52 ` Rose, Gregory V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727.222653.1937782529626247279.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).