From: Eli Cohen <eli@dev.mellanox.co.il>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: invalid requirement from ethtool?
Date: Thu, 28 Jul 2011 10:23:26 +0300 [thread overview]
Message-ID: <20110728072326.GC6750@mtldesk30> (raw)
In-Reply-To: <20110727.224309.779719590419361909.davem@davemloft.net>
On Wed, Jul 27, 2011 at 10:43:09PM -0700, David Miller wrote:
> From: Eli Cohen <eli@dev.mellanox.co.il>
> Date: Tue, 26 Jul 2011 15:42:22 +0300
>
> > I think both params zero should be allowed and mean coalescing is not
> > operational, thus we can remove these comments from ethtool.h
>
> The existing precendence has existed for more than 10 years. You can't
> just change it like this.
>
> You'll need to find a new way to encode "disabled" coalescing.
I can't see the text explicitly specifies how to "disable" coalescing.
If I ignore the specific comment that disallows both params 0, I could
interpret the text such that when they're both zero, the feature is
disabled.
BTW, I checked also Intel 10GBE Nic (ixgbe) driver and it allows
setting both 0.
next prev parent reply other threads:[~2011-07-28 7:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 12:42 invalid requirement from ethtool? Eli Cohen
2011-07-28 5:43 ` David Miller
2011-07-28 7:23 ` Eli Cohen [this message]
2011-07-28 7:37 ` David Miller
2011-07-28 10:22 ` Ben Hutchings
2011-07-28 14:55 ` Eli Cohen
2011-08-15 17:24 ` Ben Hutchings
2011-08-15 20:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728072326.GC6750@mtldesk30 \
--to=eli@dev.mellanox.co.il \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).