netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Add support for D-Link 530T rev C1 (Kernel Bug 38862)
@ 2011-07-28 23:18 Lennart Sorensen
  2011-07-28 23:34 ` Stephen Hemminger
  0 siblings, 1 reply; 3+ messages in thread
From: Lennart Sorensen @ 2011-07-28 23:18 UTC (permalink / raw)
  To: netdev
  Cc: Len Sorensen, linux-kernel, Realtek linux nic maintainers,
	Francois Romieu, drivers_network

The D-Link DGE-530T rev C1 is a re-badged Realtek 8169 named DLG10028C,
unlike the previous revisions which were skge based.  It is probably
the same as the discontinued DGE-528T (0x4300) other than the PCI ID.

The PCI ID is 0x1186:0x4302.

Adding it to r8169.c where 0x1186:0x4300 is already found makes the card
be detected and work.

This fixes https://bugzilla.kernel.org/show_bug.cgi?id=38862

Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>


diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 7d9c650..c77286e 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -239,6 +239,7 @@ static DEFINE_PCI_DEVICE_TABLE(rtl8169_pci_tbl) = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8168), 0, 0, RTL_CFG_1 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8169), 0, 0, RTL_CFG_0 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK,	0x4300), 0, 0, RTL_CFG_0 },
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK,	0x4302), 0, 0, RTL_CFG_0 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_AT,		0xc107), 0, 0, RTL_CFG_0 },
 	{ PCI_DEVICE(0x16ec,			0x0116), 0, 0, RTL_CFG_0 },
 	{ PCI_VENDOR_ID_LINKSYS,		0x1032,


-- 
Len Sorensen

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Add support for D-Link 530T rev C1 (Kernel Bug 38862)
  2011-07-28 23:18 Add support for D-Link 530T rev C1 (Kernel Bug 38862) Lennart Sorensen
@ 2011-07-28 23:34 ` Stephen Hemminger
  2011-07-28 23:35   ` Lennart Sorensen
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2011-07-28 23:34 UTC (permalink / raw)
  To: Lennart Sorensen
  Cc: netdev, linux-kernel, Realtek linux nic maintainers,
	Francois Romieu, drivers_network

On Thu, 28 Jul 2011 19:18:11 -0400
lsorense@csclub.uwaterloo.ca (Lennart Sorensen) wrote:

> The D-Link DGE-530T rev C1 is a re-badged Realtek 8169 named DLG10028C,
> unlike the previous revisions which were skge based.  It is probably
> the same as the discontinued DGE-528T (0x4300) other than the PCI ID.
> 
> The PCI ID is 0x1186:0x4302.
> 
> Adding it to r8169.c where 0x1186:0x4300 is already found makes the card
> be detected and work.
> 
> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=38862
> 
> Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>

Glad they at least changed the PCI-ID this time.
Other vendors have been known to do it wrong.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Add support for D-Link 530T rev C1 (Kernel Bug 38862)
  2011-07-28 23:34 ` Stephen Hemminger
@ 2011-07-28 23:35   ` Lennart Sorensen
  0 siblings, 0 replies; 3+ messages in thread
From: Lennart Sorensen @ 2011-07-28 23:35 UTC (permalink / raw)
  To: Stephen Hemminger
  Cc: Lennart Sorensen, netdev, linux-kernel,
	Realtek linux nic maintainers, Francois Romieu

On Thu, Jul 28, 2011 at 04:34:34PM -0700, Stephen Hemminger wrote:
> Glad they at least changed the PCI-ID this time.
> Other vendors have been known to do it wrong.

No kidding.  Ick.

-- 
Len Sorensen

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-07-28 23:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-28 23:18 Add support for D-Link 530T rev C1 (Kernel Bug 38862) Lennart Sorensen
2011-07-28 23:34 ` Stephen Hemminger
2011-07-28 23:35   ` Lennart Sorensen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).