public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: petar@smokva.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] drivers/net/tun.c: test for CAP_NET_ADMIN before attaching
Date: Fri, 29 Jul 2011 07:36:23 -0700 (PDT)	[thread overview]
Message-ID: <20110729.073623.544936174715744280.davem@davemloft.net> (raw)
In-Reply-To: <20110729142808.GA25695@pintail.smokva.net>

From: Petar Bogdanovic <petar@smokva.net>
Date: Fri, 29 Jul 2011 16:28:08 +0200

> The following change will test for CAP_NET_ADMIN before attaching, even
> if both tun->owner and tun->group equal -1.  The latter scenario can be
> reproduced with ip(8) from iproute2, when using `ip tuntap' without the
> `user' and `group' option.

Please read linux/Documentation/SubmittingPatches, for example you
need to provide a proper "Signed-off-by: " tag at the end of your
commit message.

  reply	other threads:[~2011-07-29 14:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29 14:28 [PATCH] drivers/net/tun.c: test for CAP_NET_ADMIN before attaching Petar Bogdanovic
2011-07-29 14:36 ` David Miller [this message]
2011-07-29 14:42   ` Petar Bogdanovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110729.073623.544936174715744280.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=petar@smokva.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox