From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: synapse@hippy.csoma.elte.hu, netdev@vger.kernel.org
Subject: Re: PROBLEM: BUG (NULL ptr dereference in ipv4_dst_check)
Date: Fri, 29 Jul 2011 08:19:02 -0700 (PDT) [thread overview]
Message-ID: <20110729.081902.300678107767426313.davem@davemloft.net> (raw)
In-Reply-To: <1311952306.2843.27.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 29 Jul 2011 17:11:46 +0200
> Thats tricky, because I am not sure we dont need RCU protection since we
> can now exchange dst neighbour on the fly.
>
> Following patch would only reduce the window of bug, not a complete
> fix...
>
> David, any opinion on this ?
Indeed, old code worked because we invalidated entire route cache
entry, and we never before ran arp_bind_neighbour() except on new
route cache entires before they become globally visible.
I think when we change an existing neigh we will need to release old
neigh via RCU, at a minimum.
next prev parent reply other threads:[~2011-07-29 15:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 13:18 PROBLEM: BUG (NULL ptr dereference in ipv4_dst_check) synapse
2011-07-29 13:33 ` Eric Dumazet
2011-07-29 14:26 ` synapse
2011-07-29 14:36 ` Eric Dumazet
2011-07-29 14:39 ` David Miller
2011-07-29 14:41 ` Eric Dumazet
2011-07-29 14:44 ` synapse
2011-07-29 15:11 ` Eric Dumazet
2011-07-29 15:19 ` David Miller [this message]
2011-07-29 15:43 ` Eric Dumazet
2011-07-30 5:00 ` Eric Dumazet
2011-08-01 8:57 ` synapse
2011-08-01 9:15 ` Eric Dumazet
2011-08-01 15:25 ` synapse
2011-08-03 10:34 ` David Miller
2011-08-08 13:08 ` synapse
2011-08-09 6:56 ` [PATCH] net: fix potential neighbour race in dst_ifdown() Eric Dumazet
2011-08-10 4:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110729.081902.300678107767426313.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=synapse@hippy.csoma.elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).