From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH] sunrpc: use better NUMA affinities Date: Fri, 29 Jul 2011 14:08:44 -0400 Message-ID: <20110729180844.GA28947@fieldses.org> References: <1311876249.2346.39.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20110729164214.GI23194@fieldses.org> <1311962525.2873.6.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Trond Myklebust , Neil Brown , David Miller , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev , linux-kernel , Greg Banks , bmarson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org To: Eric Dumazet Return-path: Content-Disposition: inline In-Reply-To: <1311962525.2873.6.camel@edumazet-laptop> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Fri, Jul 29, 2011 at 08:02:05PM +0200, Eric Dumazet wrote: > Le vendredi 29 juillet 2011 =C3=A0 12:42 -0400, J. Bruce Fields a =C3= =A9crit : > > On Thu, Jul 28, 2011 at 08:04:09PM +0200, Eric Dumazet wrote: > > > Use NUMA aware allocations to reduce latencies and increase throu= ghput. > > >=20 > > > sunrpc kthreads can use kthread_create_on_node() if pool_mode is > > > "percpu" or "pernode", and svc_prepare_thread()/svc_init_buffer()= can > > > also take into account NUMA node affinity for memory allocations. > > ... > > > @@ -662,14 +675,16 @@ svc_set_num_threads(struct svc_serv *serv, = struct svc_pool *pool, int nrservs) > > > nrservs--; > > > chosen_pool =3D choose_pool(serv, pool, &state); > > > =20 > > > - rqstp =3D svc_prepare_thread(serv, chosen_pool); > > > + node =3D svc_pool_map_get_node(chosen_pool->sp_id); > > > + rqstp =3D svc_prepare_thread(serv, chosen_pool, node); > >=20 > > The only correct value for the third argument there is > > svc_pool_map_get_node(chosen_pool->sp_id), so let's have > > svc_prepare_thread() call that itself. > >=20 >=20 > I have no idea of what you mean ;) >=20 > I need 'node' for the following kthread_create_on_node() Doh, of course--apologies. > > Seems OK otherwise. > >=20 > > Any suggestions on how we should test this? >=20 > I did tests on my machine, seems good. >=20 > I checked that stacks were now correct using : > "echo t > /proc/sysrq-trigger" I was wondering more about good tests of nfsd's performance on numa; that might be more of a question for Greg. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html