* [PATCH] net: add kerneldoc to skb_copy_bits()
@ 2011-07-30 4:37 Eric Dumazet
2011-08-02 1:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2011-07-30 4:37 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Since skb_copy_bits() is called from assembly, add a fat comment to make
clear we should think twice before changing its prototype.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
net/core/skbuff.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 2beda82..d6c2958 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1369,8 +1369,21 @@ pull_pages:
}
EXPORT_SYMBOL(__pskb_pull_tail);
-/* Copy some data bits from skb to kernel buffer. */
-
+/**
+ * skb_copy_bits - copy bits from skb to kernel buffer
+ * @skb: source skb
+ * @offset: offset in source
+ * @to: destination buffer
+ * @len: number of bytes to copy
+ *
+ * Copy the specified number of bytes from the source skb to the
+ * destination buffer.
+ *
+ * CAUTION ! :
+ * If its prototype is ever changed,
+ * check arch/{*}/net/{*}.S files,
+ * since it is called from BPF assembly code.
+ */
int skb_copy_bits(const struct sk_buff *skb, int offset, void *to, int len)
{
int start = skb_headlen(skb);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: add kerneldoc to skb_copy_bits()
2011-07-30 4:37 [PATCH] net: add kerneldoc to skb_copy_bits() Eric Dumazet
@ 2011-08-02 1:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-08-02 1:03 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 30 Jul 2011 06:37:31 +0200
> Since skb_copy_bits() is called from assembly, add a fat comment to make
> clear we should think twice before changing its prototype.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-02 1:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-30 4:37 [PATCH] net: add kerneldoc to skb_copy_bits() Eric Dumazet
2011-08-02 1:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).