From: David Miller <davem@davemloft.net>
To: vladz@broadcom.com
Cc: netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [PATCH net] bnx2x: Prevent restarting Tx during bnx2x_nic_unload
Date: Tue, 02 Aug 2011 01:35:52 -0700 (PDT) [thread overview]
Message-ID: <20110802.013552.1499728966977829509.davem@davemloft.net> (raw)
In-Reply-To: <201108021052.37368.vladz@broadcom.com>
From: "Vlad Zolotarov" <vladz@broadcom.com>
Date: Tue, 2 Aug 2011 10:52:37 +0300
> Tx queues were stopped before bp->state was changed to a value different
> from BNX2X_STATE_OPEN, which allowed the bnx2x_tx_int() called from the
> NAPI context to re-enable it. This then allowed the netdev->ndo_start_xmit()
> to be called in the middle of the function reset and rings freeing.
>
> This patch changes bp->state to a value different
> from BNX2X_STATE_OPEN BEFORE disabling the Tx queues in order to restore the
> broken protection against the above race in the bnx2x_tx_int().
>
> Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied, thansk Vlad.
prev parent reply other threads:[~2011-08-02 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 7:52 [PATCH net] bnx2x: Prevent restarting Tx during bnx2x_nic_unload Vlad Zolotarov
2011-08-02 8:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110802.013552.1499728966977829509.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).