From: Anton Blanchard <anton@samba.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: davem@davemloft.net, eparis@parisplace.org,
casey@schaufler-ca.com, mjt@tls.msk.ru, netdev@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] net: Fix security_socket_sendmsg() bypass problem.
Date: Thu, 4 Aug 2011 22:56:15 +1000 [thread overview]
Message-ID: <20110804225615.5aa64d74@kryten> (raw)
In-Reply-To: <201108040650.JIF90138.tFLHFJOSFOQMOV@I-love.SAKURA.ne.jp>
Hi,
> > [PATCH] net: Cap number of elements for recvmmsg and sendmmsg
> >
> > To limit the amount of time we can spend in recvmmsg and sendmmsg,
> > cap the number of elements to UIO_MAXIOV (currently 1024).
>
> Looks reasonable value. But it will return less than requested
> without setting error code. Programmers would needlessly call
> getsockopt(SO_ERROR) and get 0. Maybe -EINVAL or something is better
> than returning less than requested?
Having to call getsockopt(SO_ERROR) at all is confusing. We should
change sendmmsg to only return an error if no messages are sent. If we
do this, then the application will have already have to handle the case
where we send less messages than requested.
Returning EINVAL adds complexity to the system call that I think we
should avoid. Will send out the patches for review after some sleep.
Anton
next prev parent reply other threads:[~2011-08-04 12:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201107110304.p6B34422036886@www262.sakura.ne.jp>
[not found] ` <201107191754.22391.paul.moore@hp.com>
[not found] ` <201107200142.p6K1gKYg077046@www262.sakura.ne.jp>
[not found] ` <201107211721.14511.paul.moore@hp.com>
2011-07-22 11:41 ` Question regarding sendmmsg() Tetsuo Handa
2011-07-22 12:27 ` Tetsuo Handa
2011-07-22 15:12 ` [PATCH] net: Fix security_socket_sendmsg() bypass problem Tetsuo Handa
2011-07-22 15:22 ` David Miller
2011-07-22 17:42 ` Tetsuo Handa
2011-07-22 18:31 ` Tetsuo Handa
2011-07-23 5:20 ` Tetsuo Handa
2011-07-23 7:04 ` Michael Tokarev
2011-07-23 10:39 ` Tetsuo Handa
2011-07-25 12:20 ` Anton Blanchard
2011-07-25 13:15 ` Tetsuo Handa
2011-07-25 15:44 ` Casey Schaufler
2011-07-25 16:43 ` Tetsuo Handa
2011-07-25 17:00 ` Casey Schaufler
2011-07-26 9:55 ` Anton Blanchard
2011-07-26 11:21 ` Tetsuo Handa
2011-07-26 13:58 ` Eric Paris
2011-07-28 3:36 ` Tetsuo Handa
2011-08-02 6:07 ` David Miller
2011-08-02 9:28 ` Tetsuo Handa
2011-08-02 11:18 ` David Miller
2011-08-02 11:26 ` David Miller
2011-08-02 11:52 ` Tetsuo Handa
2011-08-02 12:01 ` David Miller
2011-08-02 13:11 ` Tetsuo Handa
2011-08-03 3:25 ` Tetsuo Handa
2011-08-03 3:38 ` David Miller
2011-08-03 3:47 ` Anton Blanchard
2011-08-03 12:20 ` Tetsuo Handa
2011-08-03 13:29 ` Anton Blanchard
2011-08-03 13:37 ` Eduard Sinelnikov
2011-08-03 21:50 ` Tetsuo Handa
2011-08-04 12:56 ` Anton Blanchard [this message]
2011-08-03 13:54 ` Anton Blanchard
2011-07-26 20:30 ` Question regarding sendmmsg() Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804225615.5aa64d74@kryten \
--to=anton@samba.org \
--cc=casey@schaufler-ca.com \
--cc=davem@davemloft.net \
--cc=eparis@parisplace.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).