Re: [PATCH, REVERT] Re: [forcedeth bug] Re: [GIT] Networking

Jiri Pirko
2011-08-05T10:26:13Z

Fri, Aug 05, 2011 at 12:19:53PM CEST, davem@davemloft.net wrote:
>From: Ingo Molnar <mingo@elte.hu>
>Date: Fri, 5 Aug 2011 12:16:25 +0200
>
>> I have reverted the two forcedeth commits:
>>
>> 0891b0e08937: forcedeth: fix vlans
>> 3326c784c9f4: forcedeth: do vlan cleanup
>>
>> and also reverted two vlan commits that the pre-cleanup driver
>> depended on:
>>
>> ffcf9b767293: vlan: kill vlan_gro_frags and vlan_gro_receive
>> 7890a5b9cbfd: vlan: kill ndo_vlan_rx_register
>>
>> and this finally gave me a working forcedeth driver. I've attached
>> the working revert below.
>
>Jiri please diagnose this immediately otherwise I will have to apply
>Ingo's reverts.
>
>Ingo has been reporting this regression for days and you haven't said
>anything. That's not acceptable.

Sorry, but first time I saw this was ~3hours ago. Looking at it
(reserving systems, compiling with ingo's config, etc) since then...

/me cannot be faster.