From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Holt Subject: Re: [RFC 5/5] [powerpc] Implement a p1010rdb clock source. Date: Mon, 8 Aug 2011 06:31:36 -0500 Message-ID: <20110808113136.GS4926@sgi.com> References: <1312641270-6018-1-git-send-email-holt@sgi.com> <1312641270-6018-6-git-send-email-holt@sgi.com> <4E3FA066.3020301@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, U Bhaskar-B22300 , Marc Kleine-Budde , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfgang Grandegger Return-path: Content-Disposition: inline In-Reply-To: <4E3FA066.3020301-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, Aug 08, 2011 at 10:37:58AM +0200, Wolfgang Grandegger wrote: > On 08/06/2011 04:34 PM, Robin Holt wrote: > > flexcan driver needs the clk_get, clk_get_rate, etc functions > > to work. This patch provides the minimum functionality. > > This needs some more general thoughts... apart from the question where > the code should go. > > Like for the MSCAN on the MPC5200, the user should be *able* to select > an appropriate clock source and divider via DTS node properties. > Currently it seems, that the DTS properties must match some > pre-configured values, most likely set by the boot loader. Please > correct me if I'm wrong. For me this is generic and should go into the > Flexcan driver. From there, a platform specific function, e.g. > flexcan_set_clock() might be called. OK. Dug a bit more. The p1010 built-in clocksource seems to be the periphereal clock frequency which is system bus frequency divided by 2. The clock source can not be changed, but the clock divider can by freezing the interface and setting the CTRL register. This appears to only be done by the boot loader. I do not see why we can not leave that functionality in the boot loader and then go back to a variation on my earlier flexcan_clk_* patch. Is that close to the direction you think we should go or have I completely misunderstood your wishes? Thanks, Robin