From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Holt Subject: Re: [RFC 5/5] [powerpc] Implement a p1010rdb clock source. Date: Mon, 8 Aug 2011 09:21:53 -0500 Message-ID: <20110808142153.GW4926@sgi.com> References: <1312641270-6018-1-git-send-email-holt@sgi.com> <1312641270-6018-6-git-send-email-holt@sgi.com> <4E3FA066.3020301@grandegger.com> <20110808113136.GS4926@sgi.com> <4E3FDFC9.7080508@grandegger.com> <20110808135630.GU4926@sgi.com> <4E3FEFBB.9050103@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, U Bhaskar-B22300 , Marc Kleine-Budde , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfgang Grandegger Return-path: Content-Disposition: inline In-Reply-To: <4E3FEFBB.9050103-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, Aug 08, 2011 at 04:16:27PM +0200, Wolfgang Grandegger wrote: > On 08/08/2011 03:56 PM, Robin Holt wrote: > >> commit 65bb8b060a873fa4f5188f2951081f6011259614 > >> Author: Bhaskar Upadhaya > >> Date: Fri Mar 4 20:27:58 2011 +0530 > > > > On a side note, that commit fixes up "fsl,flexcan-v1.0" > > ... > > + do_fixup_by_compat_u32(blob, "fsl,flexcan-v1.0", > > + "clock_freq", gd->bus_clk, 1); > > > > Should I go back to flexcan-v1.0 in my patches? > > Well, no. Let's wait. I don't think we need it. Also, it sets > "clock_freq" while > > http://lxr.linux.no/#linux+v3.0.1/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > > documents "clock-frequencies"... :-(. You answered a different question that I was asking. I was asking if I should change fsl,flexcan back to fsl,flexcan-v1.0 as documented on line 5. The clock_freq looks like a uboot change will need to be made as well. Robin