From: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
To: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [RFC 4/4] [powerpc] Add flexcan device support for p1010rdb.
Date: Tue, 9 Aug 2011 06:40:43 -0500 [thread overview]
Message-ID: <20110809114043.GN4926@sgi.com> (raw)
In-Reply-To: <4E40DDA5.1050004-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
On Tue, Aug 09, 2011 at 09:11:33AM +0200, Wolfgang Grandegger wrote:
> > + return &p1010_rdb_system_clock;
>
> Just returning fsl_get_sys_freq() here would already be fine. I'm also
> missing the factor of two here:
>
> return fsl_get_sys_freq() / 2; ????
I am working on the other comments right now as well, but this one
brought up a good question. The old algorithm in the original freescale
patches I started with actually did, essentially:
...clock.freq = DIV_ROUND_CLOSEST(fsl_get_sys_freq() / 2, 1000) * 1000
The end result was before:
...clock.freq=0x0bebc200
After:
...clock.freq=0x0bebc1fe
Is that rounding relavent?
Thanks,
Robin
next prev parent reply other threads:[~2011-08-09 11:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 5:55 [RFC 0/4] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) -V7 Robin Holt
[not found] ` <1312869313-22434-1-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-09 5:55 ` [RFC 1/4] [flexcan] Remove #include <mach/clock.h> Robin Holt
2011-08-09 5:55 ` [RFC 2/4] [flexcan] Abstract off read/write for big/little endian Robin Holt
2011-08-09 5:55 ` [RFC 3/4] [flexcan] Add of_match to platform_device definition Robin Holt
2011-08-09 5:55 ` [RFC 4/4] [powerpc] Add flexcan device support for p1010rdb Robin Holt
[not found] ` <1312869313-22434-5-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-09 6:33 ` Robin Holt
[not found] ` <20110809063319.GK4926-sJ/iWh9BUns@public.gmane.org>
2011-08-09 7:11 ` Wolfgang Grandegger
[not found] ` <4E40DDA5.1050004-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-09 11:40 ` Robin Holt [this message]
[not found] ` <20110809114043.GN4926-sJ/iWh9BUns@public.gmane.org>
2011-08-09 12:04 ` Marc Kleine-Budde
2011-08-09 12:04 ` Robin Holt
2011-08-09 12:33 ` Marc Kleine-Budde
[not found] ` <4E41291B.3020001-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-09 12:40 ` Robin Holt
[not found] ` <20110809124042.GR4926-sJ/iWh9BUns@public.gmane.org>
2011-08-09 13:09 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809114043.GN4926@sgi.com \
--to=holt-sj/iwh9buns@public.gmane.org \
--cc=B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).