From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Subject: Re: [PATCH] net_sched: prio: use qdisc_dequeue_peeked
Date: Tue, 9 Aug 2011 15:45:32 +0200 [thread overview]
Message-ID: <20110809134532.GA28510@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <1312894585.2371.24.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > Eric, does this look correct to you?
> > I am not sure if sfq needs fixing instead of this patch here.
> >
> > diff --git a/net/sched/sch_prio.c b/net/sched/sch_prio.c
> > index 2a318f2..b5d56a2 100644
> > --- a/net/sched/sch_prio.c
> > +++ b/net/sched/sch_prio.c
> > @@ -112,7 +112,7 @@ static struct sk_buff *prio_dequeue(struct Qdisc *sch)
> >
> > for (prio = 0; prio < q->bands; prio++) {
> > struct Qdisc *qdisc = q->queues[prio];
> > - struct sk_buff *skb = qdisc->dequeue(qdisc);
> > + struct sk_buff *skb = qdisc_dequeue_peeked(qdisc);
> > if (skb) {
> > qdisc_bstats_update(sch, skb);
> > sch->q.qlen--;
>
>
> Hi Florian
>
> Are you sure this patch is still needed, after commit
> e1738bd9cecc5c867b0e2996470c1ff20f66ba79
> (sch_sfq: fix sfq_enqueue())
Yes, I double checked. This patch is applied, also
I see HFSC complaints even without that code path touched by
"sch_sfq: fix sfq_enqueue" being hit.
next prev parent reply other threads:[~2011-08-09 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 12:04 [PATCH] net_sched: prio: use qdisc_dequeue_peeked Florian Westphal
2011-08-09 12:56 ` Eric Dumazet
2011-08-09 13:45 ` Florian Westphal [this message]
2011-08-10 4:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809134532.GA28510@Chamillionaire.breakpoint.cc \
--to=fw@strlen.de \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox