From: David Miller <davem@davemloft.net>
To: mikew@google.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp: initialize variable ecn_ok in syncookies path
Date: Wed, 10 Aug 2011 22:00:34 -0700 (PDT) [thread overview]
Message-ID: <20110810.220034.1867514011580098205.davem@davemloft.net> (raw)
In-Reply-To: <1313002284-2362-1-git-send-email-mikew@google.com>
From: Mike Waychison <mikew@google.com>
Date: Wed, 10 Aug 2011 11:51:24 -0700
> Using a gcc 4.4.3, warnings are emitted for a possibly uninitialized use
> of ecn_ok.
>
> This can happen if cookie_check_timestamp() returns due to not
> having seen a timestamp. Defaulting to ecn off seems like a
> reasonable thing to do in this case, so initialized ecn_ok to false.
>
> Signed-off-by: Mike Waychison <mikew@google.com>
Applied, thanks Mike.
prev parent reply other threads:[~2011-08-11 5:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 18:51 [PATCH] tcp: initialize variable ecn_ok in syncookies path Mike Waychison
2011-08-11 5:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810.220034.1867514011580098205.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).