From: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
To: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Kumar Gala
<galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
Subject: Re: [PATCH v10 4/5] [powerpc] Add flexcan device support for p1010rdb.
Date: Wed, 10 Aug 2011 05:15:36 -0500 [thread overview]
Message-ID: <20110810101535.GO4926@sgi.com> (raw)
In-Reply-To: <4E4255B1.6050001-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Wed, Aug 10, 2011 at 11:56:01AM +0200, Marc Kleine-Budde wrote:
> On 08/10/2011 05:06 AM, Robin Holt wrote:
> > diff --git a/arch/powerpc/platforms/85xx/clock.c b/arch/powerpc/platforms/85xx/clock.c
> > new file mode 100644
> > index 0000000..16fae04
> > --- /dev/null
> > +++ b/arch/powerpc/platforms/85xx/clock.c
> > @@ -0,0 +1,53 @@
...
> > +void __init mpc85xx_clk_init(void)
> > +{
> > + clk_functions = mpc85xx_clk_functions;
> > +}
> > +
>
> git is even picker then me: "new blank line at EOF."
> please fix
That reminded me that I have slacked on using checkpatch.pl in a few
resends and it really does not like this patch at all so I will rework
the patch with its concerns. I am going to hold off on resending until
there are more substantial changes.
Thanks,
Robin
next prev parent reply other threads:[~2011-08-10 10:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 3:05 [PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) Robin Holt
[not found] ` <1312945564-6626-1-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-10 3:06 ` [PATCH v10 1/5] [flexcan] Remove #include <mach/clock.h> Robin Holt
2011-08-10 3:06 ` [PATCH v10 2/5] [flexcan] Abstract off read/write for big/little endian Robin Holt
2011-08-10 3:06 ` [PATCH v10 3/5] [flexcan] Add of_match to platform_device definition Robin Holt
[not found] ` <1312945564-6626-4-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-10 14:33 ` Robin Holt
2011-08-10 3:06 ` [PATCH v10 4/5] [powerpc] Add flexcan device support for p1010rdb Robin Holt
[not found] ` <1312945564-6626-5-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-10 9:56 ` Marc Kleine-Budde
[not found] ` <4E4255B1.6050001-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-10 10:15 ` Robin Holt [this message]
2011-08-10 3:06 ` [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding Robin Holt
[not found] ` <1312945564-6626-6-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-10 8:15 ` Robert Schwebel
2011-08-10 13:47 ` Wolfgang Grandegger
[not found] ` <4E428BFF.7060402-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-10 14:15 ` Robin Holt
2011-08-10 14:36 ` U Bhaskar-B22300
[not found] ` <9C64B7751C3BCA41B64A68E23005A7BE1C6A21-TcFNo7jSaXPiTqIcKZ1S2K4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-08-10 16:00 ` Robin Holt
[not found] ` <20110810160054.GT4926-sJ/iWh9BUns@public.gmane.org>
2011-08-10 16:53 ` Kumar Gala
[not found] ` <63306A24-3FBF-4DAA-A0B9-6005F56BB76F-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-08-10 17:16 ` Robin Holt
[not found] ` <20110810171600.GV4926-sJ/iWh9BUns@public.gmane.org>
2011-08-10 17:17 ` Kumar Gala
[not found] ` <8C9817C6-735D-4B7C-A03B-5661C04C725A-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-08-10 17:20 ` Robin Holt
[not found] ` <20110810172040.GX4926-sJ/iWh9BUns@public.gmane.org>
2011-08-10 17:26 ` Kumar Gala
2011-08-10 18:23 ` Wolfgang Grandegger
2011-08-10 18:27 ` Scott Wood
[not found] ` <4E42CDA8.5050902-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-08-10 18:35 ` Robin Holt
2011-08-10 18:39 ` Scott Wood
[not found] ` <20110810141550.GQ4926-sJ/iWh9BUns@public.gmane.org>
2011-08-10 14:41 ` Wolfgang Grandegger
[not found] ` <4E42987F.9040304-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-10 14:46 ` Kumar Gala
2011-08-10 14:45 ` Kumar Gala
[not found] ` <8ED8063F-7227-402A-89D5-7CE69241AF9C-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-08-10 15:35 ` Robin Holt
2011-08-10 10:09 ` Robin Holt
2011-08-10 10:01 ` [PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) Marc Kleine-Budde
[not found] ` <4E425716.4010104-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-10 10:11 ` Robin Holt
[not found] ` <20110810101113.GN4926-sJ/iWh9BUns@public.gmane.org>
2011-08-10 10:24 ` Marc Kleine-Budde
2011-08-10 11:09 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810101535.GO4926@sgi.com \
--to=holt-sj/iwh9buns@public.gmane.org \
--cc=B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).