From: Jamie Iles <jamie@jamieiles.com>
To: Joe Perches <joe@perches.com>
Cc: Jamie Iles <jamie@jamieiles.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
plagnioj@jcrosoft.com
Subject: Re: [PATCHv3 4/9] macb: convert printk to netdev_ and friends
Date: Thu, 11 Aug 2011 10:01:47 +0100 [thread overview]
Message-ID: <20110811090147.GD2732@pulham.picochip.com> (raw)
In-Reply-To: <1312921227.11924.35.camel@Joe-Laptop>
On Tue, Aug 09, 2011 at 01:20:27PM -0700, Joe Perches wrote:
> On Tue, 2011-08-09 at 10:16 +0100, Jamie Iles wrote:
> > macb is already using the dev_dbg() and friends helpers so use netdev_()
> > along with a pr_fmt() definition to make the printing a little cleaner.
> []
> > diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> []
> > @@ -8,6 +8,7 @@
> []
> > +#define pr_fmt(fmt) "macb: " fmt
>
> Hi Jamie.
>
> Just trivia.
>
> Please use #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> instead. There would be no output difference.
>
> That'll make it easier to remove later when all of
> of these #defines pr_fmt that use just KBUILD_MODNAME
> can be removed.
I hadn't noticed KBUILD_MODNAME before, thanks for pointing that out
Joe. I'll update with this change.
Jamie
next prev parent reply other threads:[~2011-08-11 9:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 9:16 [PATCHv3 0/9] macb: add support for Cadence GEM Jamie Iles
2011-08-09 9:16 ` [PATCHv3 1/9] at91: provide macb clks with "pclk" and "hclk" name Jamie Iles
2011-08-09 14:49 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-09 14:51 ` [PATCH 1/9 v4] " Jean-Christophe PLAGNIOL-VILLARD
2011-08-09 9:16 ` [PATCHv3 2/9] macb: remove conditional clk handling Jamie Iles
2011-08-09 14:52 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-09 9:16 ` [PATCHv3 3/9] macb: unify at91 and avr32 platform data Jamie Iles
2011-08-09 14:53 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-09 9:16 ` [PATCHv3 4/9] macb: convert printk to netdev_ and friends Jamie Iles
2011-08-09 20:20 ` Joe Perches
2011-08-11 9:01 ` Jamie Iles [this message]
2011-08-09 9:16 ` [PATCHv3 5/9] macb: initial support for Cadence GEM Jamie Iles
2011-08-09 14:55 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-09 9:16 ` [PATCHv3 6/9] macb: support higher rate GEM MDIO clock divisors Jamie Iles
2011-08-09 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-09 9:16 ` [PATCHv3 7/9] macb: support statistics for GEM devices Jamie Iles
2011-08-09 14:57 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-09 9:16 ` [PATCHv3 8/9] macb: support DMA bus widths > 32 bits Jamie Iles
2011-08-09 14:57 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-09 9:16 ` [PATCHv3 9/9] macb: allow GEM to have configurable receive buffer size Jamie Iles
2011-08-09 14:59 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-09 14:59 ` [PATCHv3 0/9] macb: add support for Cadence GEM Jean-Christophe PLAGNIOL-VILLARD
2011-08-11 9:21 ` Jamie Iles
2011-08-23 9:34 ` Jamie Iles
2011-08-28 6:08 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811090147.GD2732@pulham.picochip.com \
--to=jamie@jamieiles.com \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).