From: Josh Boyer <jwboyer@redhat.com>
To: Oliver Neukum <oliver@neukum.org>,
Alexey ORISHKO <alexey.orishko@stericsson.com>
Cc: gregkh@suse.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v4] usbnet/cdc_ncm: Don't use stack variables for DMA
Date: Fri, 12 Aug 2011 11:07:16 -0400 [thread overview]
Message-ID: <20110812150715.GD3014@zod.bos.redhat.com> (raw)
In-Reply-To: <20110808123406.GA2526@zod.bos.redhat.com>
On Mon, Aug 08, 2011 at 08:34:06AM -0400, Josh Boyer wrote:
> The cdc_ncm driver still has a few places where stack variables are
> passed to the cdc_ncm_do_request function. This triggers a stack trace in
> lib/dma-debug.c if the CONFIG_DEBUG_DMA_API option is set.
>
> Adjust these calls to pass parameters that have been allocated with
> kzalloc.
>
> Signed-off-by: Josh Boyer <jwboyer@redhat.com>
> ---
> v4: Rebase against 3.1-rc1
> v3: Fix checkpatch errors
> v2: Fix leak in error path
>
> drivers/net/usb/cdc_ncm.c | 47 ++++++++++++++++++++++++++++++++++++--------
> 1 files changed, 38 insertions(+), 9 deletions(-)
Just curious, but which tree would this be pulled into? usb or net or?
josh
next prev parent reply other threads:[~2011-08-12 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 12:34 [PATCH v4] usbnet/cdc_ncm: Don't use stack variables for DMA Josh Boyer
2011-08-12 15:07 ` Josh Boyer [this message]
2011-08-12 15:11 ` David Miller
2011-08-14 1:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812150715.GD3014@zod.bos.redhat.com \
--to=jwboyer@redhat.com \
--cc=alexey.orishko@stericsson.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox