Netdev List
 help / color / mirror / Atom feed
From: Jiri Pirko <jpirko@redhat.com>
To: romieu@fr.zoreil.com
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	stephan.baerwolf@tu-ilmenau.de
Subject: re commit d4f73c8e459d355e10051174d859ffd0ef5764c0
Date: Mon, 15 Aug 2011 14:12:14 +0200	[thread overview]
Message-ID: <20110815121213.GA2013@minipsycho.brq.redhat.com> (raw)

Hi Francois.

Looking at mentioned commit, Not sure if the functionality is correct.
Your patch message says:

The non-tagged interface is filtered out as soon as a tagged
(!= 0) interface is created. Its traffic appears again when an
zero-tagged interface is created.

I would presume non-tagged packet would not be filtered any time.
Removing "WORD_REG_BITS_ON(MCFG_RTGOPT, &regs->MCFG);" should probably
do the trick.

Thanks.

Jirka


             reply	other threads:[~2011-08-15 12:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-15 12:12 Jiri Pirko [this message]
2011-08-19  5:03 ` re commit d4f73c8e459d355e10051174d859ffd0ef5764c0 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110815121213.GA2013@minipsycho.brq.redhat.com \
    --to=jpirko@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=stephan.baerwolf@tu-ilmenau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox