netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net_sched: fix port mirror/redirect stats reporting
@ 2011-08-15 15:25 jamal
  2011-08-18  3:10 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: jamal @ 2011-08-15 15:25 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

commit 6a51508a01671114c236602d071d4bff53422c60
Author: Jamal Hadi Salim <jhs@mojatatu.com>
Date:   Mon Aug 15 11:17:06 2011 -0400

    [PATCH] net_sched: fix port mirror/redirect stats reporting
    
    When a redirected or mirrored packet is dropped by the target
    device we need to record statistics.
    
    Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c
index 961386e..d5ef6ec 100644
--- a/net/sched/act_mirred.c
+++ b/net/sched/act_mirred.c
@@ -196,8 +196,7 @@ static int tcf_mirred(struct sk_buff *skb, struct tc_action *a,
 
 	skb2->skb_iif = skb->dev->ifindex;
 	skb2->dev = dev;
-	dev_queue_xmit(skb2);
-	err = 0;
+	err = dev_queue_xmit(skb2);
 
 out:
 	if (err) {



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net_sched: fix port mirror/redirect stats reporting
  2011-08-15 15:25 [PATCH] net_sched: fix port mirror/redirect stats reporting jamal
@ 2011-08-18  3:10 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-08-18  3:10 UTC (permalink / raw)
  To: jhs, hadi; +Cc: netdev

From: jamal <hadi@cyberus.ca>
Date: Mon, 15 Aug 2011 11:25:40 -0400

> commit 6a51508a01671114c236602d071d4bff53422c60
> Author: Jamal Hadi Salim <jhs@mojatatu.com>
> Date:   Mon Aug 15 11:17:06 2011 -0400
> 
>     [PATCH] net_sched: fix port mirror/redirect stats reporting
>     
>     When a redirected or mirrored packet is dropped by the target
>     device we need to record statistics.
>     
>     Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-18  3:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-15 15:25 [PATCH] net_sched: fix port mirror/redirect stats reporting jamal
2011-08-18  3:10 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).