From: David Miller <davem@davemloft.net>
To: jj@chaosbits.net
Cc: khc@pm.waw.pl, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH][Trivial] net/wan/hdlc_ppp: remove dead goto
Date: Thu, 18 Aug 2011 22:02:49 -0700 (PDT) [thread overview]
Message-ID: <20110818.220249.1523360015062657902.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1108130138100.7387@swampdragon.chaosbits.net>
From: Jesper Juhl <jj@chaosbits.net>
Date: Sat, 13 Aug 2011 01:39:43 +0200 (CEST)
> From: Jesper Juhl <jj@chaosbits.net>
>
> We'll either hit one of the case labels or the default in the switch
> and in all cases do we then 'goto out', so having 'goto out' right
> after the switch is pointless as we can never hit it - remove it.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Probably a lot cleaner to use break statements in the switch() statement
and keep this goto in place.
That's more straightforward control flow than what this thing is doing.
next prev parent reply other threads:[~2011-08-19 5:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 23:39 [PATCH][Trivial] net/wan/hdlc_ppp: remove dead goto Jesper Juhl
2011-08-19 5:02 ` David Miller [this message]
2011-08-21 21:38 ` Jesper Juhl
2011-08-22 20:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110818.220249.1523360015062657902.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jj@chaosbits.net \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).