From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: add APIs for manipulating skb page fragments. Date: Mon, 22 Aug 2011 17:00:20 -0700 (PDT) Message-ID: <20110822.170020.2116490055045958490.davem@davemloft.net> References: <1313771100-22993-1-git-send-email-ian.campbell@citrix.com> <20110820.173133.1612902138924735868.davem@davemloft.net> <1313915037.17978.686.camel@dagon.hellion.org.uk> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com, mirq-linux@rere.qmqm.pl To: Ian.Campbell@eu.citrix.com Return-path: Received: from shards.monkeyblade.net ([198.137.202.13]:56489 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992Ab1HWAAb (ORCPT ); Mon, 22 Aug 2011 20:00:31 -0400 In-Reply-To: <1313915037.17978.686.camel@dagon.hellion.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: From: Ian Campbell Date: Sun, 21 Aug 2011 09:23:57 +0100 > On Sun, 2011-08-21 at 01:31 +0100, David Miller wrote: >> From: Ian Campbell >> Date: Fri, 19 Aug 2011 17:25:00 +0100 >> >> > The primary aim is to add skb_frag_(ref|unref) in order to remove the use of >> > bare get/put_page on SKB pages fragments and to isolate users from subsequent >> > changes to the skb_frag_t data structure. >> > >> > Signed-off-by: Ian Campbell >> >> You're going to have to protect all of the things using the interfaces >> from linux/dma-mapping.h with CONFIG_HAS_DMA otherwise it won't build >> on platforms like S390. > > s390 is one of the arches which I build tested and I initially saw this > issue too. I did add CONFIG_HAS_DMA but it turns out that > linux/dma-mapping.h takes care of this by including > asm-generic/dma-mapping-broken.h for you so I removed the #ifdef again. > The header defines the prototypes to allow building but causes a link > time failure if anything actually uses the interfaces. > > I just tested a s390x defconfig build again and it appears to be fine. Thanks for explaining this. Patch applied, thanks!