* linux-next: boot test failure (net tree) @ 2011-08-17 0:01 Stephen Rothwell 2011-08-17 0:15 ` David Miller 0 siblings, 1 reply; 19+ messages in thread From: Stephen Rothwell @ 2011-08-17 0:01 UTC (permalink / raw) To: David Miller, netdev; +Cc: linux-next, linux-kernel, Jeff Kirsher [-- Attachment #1: Type: text/plain, Size: 761 bytes --] Hi all, I do build and boot tests for various PowerPC servers I have access to. Last night's test failed due to the fact that their ethernet drivers are not longer being built. In particular, CONFIG_TIGON3 newly depends on CONFIG_NET_VENDOR_BROADCOM which will no be selected when doing a "make oldconfig" from a working config. Similarly for CONFIG_IBM_VETH and (the new) CONFIG_VENDOR_IBM. The original config had both CONFIG_TIGON3 and CONFIG_IBM_VETH set (to y and m resp.) and the final config had neither. These Kconfig changes need to be revised so that "make oldconfig" from a working config builds the same set of drivers ... -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-17 0:01 linux-next: boot test failure (net tree) Stephen Rothwell @ 2011-08-17 0:15 ` David Miller 2011-08-17 0:50 ` Stephen Rothwell 0 siblings, 1 reply; 19+ messages in thread From: David Miller @ 2011-08-17 0:15 UTC (permalink / raw) To: sfr; +Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Wed, 17 Aug 2011 10:01:46 +1000 > In particular, CONFIG_TIGON3 newly depends on > CONFIG_NET_VENDOR_BROADCOM which will no be selected when doing a > "make oldconfig" from a working config. When you type "make oldconfig" with an existing .config it prompts you for those vendor guards, giving you ample opportunity to say yes to them. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-17 0:15 ` David Miller @ 2011-08-17 0:50 ` Stephen Rothwell 2011-08-17 0:56 ` David Miller 2011-08-18 5:22 ` Stephen Rothwell 0 siblings, 2 replies; 19+ messages in thread From: Stephen Rothwell @ 2011-08-17 0:50 UTC (permalink / raw) To: David Miller; +Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher [-- Attachment #1: Type: text/plain, Size: 803 bytes --] Hi Dave, On Tue, 16 Aug 2011 17:15:25 -0700 (PDT) David Miller <davem@davemloft.net> wrote: > > From: Stephen Rothwell <sfr@canb.auug.org.au> > Date: Wed, 17 Aug 2011 10:01:46 +1000 > > > In particular, CONFIG_TIGON3 newly depends on > > CONFIG_NET_VENDOR_BROADCOM which will no be selected when doing a > > "make oldconfig" from a working config. > > When you type "make oldconfig" with an existing .config it prompts you > for those vendor guards, giving you ample opportunity to say yes to > them. Which is a bit of a pain for automated systems. Ours does (essentially): yes '' | make oldconfig We really don't want to select every new config item that comes along. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-17 0:50 ` Stephen Rothwell @ 2011-08-17 0:56 ` David Miller 2011-08-17 1:19 ` Ben Hutchings 2011-08-17 1:21 ` Stephen Rothwell 2011-08-18 5:22 ` Stephen Rothwell 1 sibling, 2 replies; 19+ messages in thread From: David Miller @ 2011-08-17 0:56 UTC (permalink / raw) To: sfr; +Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Wed, 17 Aug 2011 10:50:02 +1000 > Which is a bit of a pain for automated systems. Ours does (essentially): > > yes '' | make oldconfig > > We really don't want to select every new config item that comes along. If you're indeed piping "yes" output to "make oldconfig" on an existing config, it would select the new guards for you. This happens on other occaisions, I see new group guards all the time when I resync my net and net-next trees with Linus. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-17 0:56 ` David Miller @ 2011-08-17 1:19 ` Ben Hutchings 2011-08-17 3:04 ` David Miller 2011-08-17 1:21 ` Stephen Rothwell 1 sibling, 1 reply; 19+ messages in thread From: Ben Hutchings @ 2011-08-17 1:19 UTC (permalink / raw) To: David Miller; +Cc: sfr, netdev, linux-next, linux-kernel, jeffrey.t.kirsher On Tue, 2011-08-16 at 17:56 -0700, David Miller wrote: > From: Stephen Rothwell <sfr@canb.auug.org.au> > Date: Wed, 17 Aug 2011 10:50:02 +1000 > > > Which is a bit of a pain for automated systems. Ours does (essentially): > > > > yes '' | make oldconfig > > > > We really don't want to select every new config item that comes along. > > If you're indeed piping "yes" output to "make oldconfig" on an > existing config, it would select the new guards for you. [....] If you were to use just "yes", then of course it would. But since there is no explicit default, "yes ''" will deselect them. Maybe these guards should have "default y"? Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-17 1:19 ` Ben Hutchings @ 2011-08-17 3:04 ` David Miller 0 siblings, 0 replies; 19+ messages in thread From: David Miller @ 2011-08-17 3:04 UTC (permalink / raw) To: bhutchings; +Cc: sfr, netdev, linux-next, linux-kernel, jeffrey.t.kirsher From: Ben Hutchings <bhutchings@solarflare.com> Date: Wed, 17 Aug 2011 02:19:12 +0100 > If you were to use just "yes", then of course it would. But since there > is no explicit default, "yes ''" will deselect them. > > Maybe these guards should have "default y"? The point is to declutter xconfig and friends, if it defaults to 'y' everything will just always expand. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-17 0:56 ` David Miller 2011-08-17 1:19 ` Ben Hutchings @ 2011-08-17 1:21 ` Stephen Rothwell 2011-08-17 3:05 ` David Miller 1 sibling, 1 reply; 19+ messages in thread From: Stephen Rothwell @ 2011-08-17 1:21 UTC (permalink / raw) To: David Miller; +Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher [-- Attachment #1: Type: text/plain, Size: 964 bytes --] Hi Dave, On Tue, 16 Aug 2011 17:56:57 -0700 (PDT) David Miller <davem@davemloft.net> wrote: > > From: Stephen Rothwell <sfr@canb.auug.org.au> > Date: Wed, 17 Aug 2011 10:50:02 +1000 > > > Which is a bit of a pain for automated systems. Ours does (essentially): > > > > yes '' | make oldconfig > > > > We really don't want to select every new config item that comes along. > > If you're indeed piping "yes" output to "make oldconfig" on an > existing config, it would select the new guards for you. Notice the '' that just is the same as typing return to every prompt. In the case of these new gueards, that means 'n'. This will be the same with "make silentoldconfig". > This happens on other occaisions, I see new group guards all > the time when I resync my net and net-next trees with Linus. "All the time"? really? -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-17 1:21 ` Stephen Rothwell @ 2011-08-17 3:05 ` David Miller 0 siblings, 0 replies; 19+ messages in thread From: David Miller @ 2011-08-17 3:05 UTC (permalink / raw) To: sfr; +Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Wed, 17 Aug 2011 11:21:10 +1000 > On Tue, 16 Aug 2011 17:56:57 -0700 (PDT) David Miller <davem@davemloft.net> wrote: >> >> This happens on other occaisions, I see new group guards all >> the time when I resync my net and net-next trees with Linus. > > "All the time"? really? I can't think of too many days during the merge window where this doesn't happen, quite frankly. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-17 0:50 ` Stephen Rothwell 2011-08-17 0:56 ` David Miller @ 2011-08-18 5:22 ` Stephen Rothwell 2011-08-18 5:40 ` Jeff Kirsher 2011-08-18 5:53 ` David Miller 1 sibling, 2 replies; 19+ messages in thread From: Stephen Rothwell @ 2011-08-18 5:22 UTC (permalink / raw) To: David Miller Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher, Michael Neuling, Linus, Andrew Morton [-- Attachment #1: Type: text/plain, Size: 1726 bytes --] Hi Dave, On Wed, 17 Aug 2011 10:50:02 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Tue, 16 Aug 2011 17:15:25 -0700 (PDT) David Miller <davem@davemloft.net> wrote: > > > > From: Stephen Rothwell <sfr@canb.auug.org.au> > > Date: Wed, 17 Aug 2011 10:01:46 +1000 > > > > > In particular, CONFIG_TIGON3 newly depends on > > > CONFIG_NET_VENDOR_BROADCOM which will no be selected when doing a > > > "make oldconfig" from a working config. > > > > When you type "make oldconfig" with an existing .config it prompts you > > for those vendor guards, giving you ample opportunity to say yes to > > them. > > Which is a bit of a pain for automated systems. Ours does (essentially): > > yes '' | make oldconfig > > We really don't want to select every new config item that comes along. So, Mikey did a test for me (he was bitten by this today). Just one of the powerpc configs (pseries_defconfig which should, in theory, build a kernel that will boot on almost all our POWER server machines) loses all these drivers if you do a "make pseries_defconfig": -CONFIG_IBMVETH=y -CONFIG_PCNET32=y -CONFIG_E100=y -CONFIG_ACENIC=m -CONFIG_ACENIC_OMIT_TIGON_I=y -CONFIG_E1000=y -CONFIG_E1000E=y -CONFIG_BNX2=m -CONFIG_CHELSIO_T3=m -CONFIG_CHELSIO_T4=m -CONFIG_IXGBE=m -CONFIG_IXGB=m -CONFIG_S2IO=m -CONFIG_MYRI10GE=m -CONFIG_NETXEN_NIC=m -CONFIG_QLGE=m -CONFIG_BE2NET=m That is just one of our deconfigs ... there are over 400 defconfigs in the kernel and a lot of them will need to be updated. Mikey asks: Will Dave take these updates if we get Acks from the maintainers? :-) -- Cheers, Stephen Rothwell sfr@canb.auug.org.au [-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-18 5:22 ` Stephen Rothwell @ 2011-08-18 5:40 ` Jeff Kirsher 2011-08-18 5:53 ` David Miller 1 sibling, 0 replies; 19+ messages in thread From: Jeff Kirsher @ 2011-08-18 5:40 UTC (permalink / raw) To: Stephen Rothwell Cc: David Miller, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Neuling, Linus, Andrew Morton [-- Attachment #1: Type: text/plain, Size: 2308 bytes --] On Wed, 2011-08-17 at 22:22 -0700, Stephen Rothwell wrote: > Hi Dave, > > On Wed, 17 Aug 2011 10:50:02 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > On Tue, 16 Aug 2011 17:15:25 -0700 (PDT) David Miller <davem@davemloft.net> wrote: > > > > > > From: Stephen Rothwell <sfr@canb.auug.org.au> > > > Date: Wed, 17 Aug 2011 10:01:46 +1000 > > > > > > > In particular, CONFIG_TIGON3 newly depends on > > > > CONFIG_NET_VENDOR_BROADCOM which will no be selected when doing a > > > > "make oldconfig" from a working config. > > > > > > When you type "make oldconfig" with an existing .config it prompts you > > > for those vendor guards, giving you ample opportunity to say yes to > > > them. > > > > Which is a bit of a pain for automated systems. Ours does (essentially): > > > > yes '' | make oldconfig > > > > We really don't want to select every new config item that comes along. > > So, Mikey did a test for me (he was bitten by this today). Just one of > the powerpc configs (pseries_defconfig which should, in theory, build a > kernel that will boot on almost all our POWER server machines) loses all > these drivers if you do a "make pseries_defconfig": > > -CONFIG_IBMVETH=y > -CONFIG_PCNET32=y > -CONFIG_E100=y > -CONFIG_ACENIC=m > -CONFIG_ACENIC_OMIT_TIGON_I=y > -CONFIG_E1000=y > -CONFIG_E1000E=y > -CONFIG_BNX2=m > -CONFIG_CHELSIO_T3=m > -CONFIG_CHELSIO_T4=m > -CONFIG_IXGBE=m > -CONFIG_IXGB=m > -CONFIG_S2IO=m > -CONFIG_MYRI10GE=m > -CONFIG_NETXEN_NIC=m > -CONFIG_QLGE=m > -CONFIG_BE2NET=m > > That is just one of our deconfigs ... there are over 400 defconfigs in > the kernel and a lot of them will need to be updated. > > Mikey asks: Will Dave take these updates if we get Acks from the > maintainers? :-) > I am open to the idea. I considered updating the the defconfig's, but was not sure was the best way of doing the changes. I was not sure making these changes in Dave's net-next tree would not upset the arch maintainer's, especially if there is a better tree(s) for the changes. I am in the finishing up the patches for drivers/net/ {FDDI, PPP, SLIP, HIPPI, etc.) and since I started this change, I would sign-up for making the defconfig changes if that helps. Cheers, Jeff [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-18 5:22 ` Stephen Rothwell 2011-08-18 5:40 ` Jeff Kirsher @ 2011-08-18 5:53 ` David Miller 2011-08-22 1:30 ` Stephen Rothwell 1 sibling, 1 reply; 19+ messages in thread From: David Miller @ 2011-08-18 5:53 UTC (permalink / raw) To: sfr Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher, mikey, torvalds, akpm From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Thu, 18 Aug 2011 15:22:14 +1000 > Mikey asks: Will Dave take these updates if we get Acks from the > maintainers? :-) I'm more than happy to :-) ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-18 5:53 ` David Miller @ 2011-08-22 1:30 ` Stephen Rothwell 2011-08-23 1:40 ` Stephen Rothwell 0 siblings, 1 reply; 19+ messages in thread From: Stephen Rothwell @ 2011-08-22 1:30 UTC (permalink / raw) To: David Miller Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher, mikey, torvalds, akpm, ppc-dev, Benjamin Herrenschmidt, Paul Mackerras Hi Dave, On Wed, 17 Aug 2011 22:53:56 -0700 (PDT) David Miller <davem@davemloft.net> wrote: > > From: Stephen Rothwell <sfr@canb.auug.org.au> > Date: Thu, 18 Aug 2011 15:22:14 +1000 > > > Mikey asks: Will Dave take these updates if we get Acks from the > > maintainers? :-) > > I'm more than happy to :-) Here's what I am applying as a merge fixup to the net tree today so that my ppc64_defconfig builds actually build more or less the same set of drivers as before this rearrangement. This has no Acks yet, but produces a very similar .config to what we had previously. From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Mon, 22 Aug 2011 11:23:56 +1000 Subject: [PATCH] powerpc: update ppc64_defconfig for net device movement Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- arch/powerpc/configs/ppc64_defconfig | 71 +++++++++++++-------------------- 1 files changed, 28 insertions(+), 43 deletions(-) diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/ppc64_defconfig index 84a685a5..9a424c4 100644 --- a/arch/powerpc/configs/ppc64_defconfig +++ b/arch/powerpc/configs/ppc64_defconfig @@ -49,7 +49,6 @@ CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y CONFIG_HZ_100=y CONFIG_BINFMT_MISC=m -CONFIG_HOTPLUG_CPU=y CONFIG_KEXEC=y CONFIG_IRQ_ALL_CPUS=y CONFIG_MEMORY_HOTREMOVE=y @@ -75,7 +74,6 @@ CONFIG_INET_ESP=m CONFIG_INET_IPCOMP=m # CONFIG_IPV6 is not set CONFIG_NETFILTER=y -CONFIG_NETFILTER_NETLINK_QUEUE=m CONFIG_NF_CONNTRACK=m CONFIG_NF_CONNTRACK_EVENTS=y CONFIG_NF_CT_PROTO_SCTP=m @@ -133,7 +131,6 @@ CONFIG_NETFILTER_XT_MATCH_U32=m CONFIG_NF_CONNTRACK_IPV4=m CONFIG_IP_NF_QUEUE=m CONFIG_IP_NF_IPTABLES=m -CONFIG_IP_NF_MATCH_ADDRTYPE=m CONFIG_IP_NF_MATCH_AH=m CONFIG_IP_NF_MATCH_ECN=m CONFIG_IP_NF_MATCH_TTL=m @@ -145,7 +142,6 @@ CONFIG_NF_NAT=m CONFIG_IP_NF_TARGET_MASQUERADE=m CONFIG_IP_NF_TARGET_NETMAP=m CONFIG_IP_NF_TARGET_REDIRECT=m -CONFIG_NF_NAT_SNMP_BASIC=m CONFIG_IP_NF_MANGLE=m CONFIG_IP_NF_TARGET_CLUSTERIP=m CONFIG_IP_NF_TARGET_ECN=m @@ -176,7 +172,6 @@ CONFIG_CHR_DEV_SG=y CONFIG_SCSI_MULTI_LUN=y CONFIG_SCSI_CONSTANTS=y CONFIG_SCSI_FC_ATTRS=y -CONFIG_SCSI_SAS_ATTRS=m CONFIG_SCSI_CXGB3_ISCSI=m CONFIG_SCSI_CXGB4_ISCSI=m CONFIG_SCSI_BNX2_ISCSI=m @@ -208,13 +203,6 @@ CONFIG_DM_SNAPSHOT=m CONFIG_DM_MIRROR=m CONFIG_DM_ZERO=m CONFIG_DM_MULTIPATH=m -CONFIG_IEEE1394=y -CONFIG_IEEE1394_OHCI1394=y -CONFIG_IEEE1394_SBP2=m -CONFIG_IEEE1394_ETH1394=m -CONFIG_IEEE1394_RAWIO=y -CONFIG_IEEE1394_VIDEO1394=m -CONFIG_IEEE1394_DV1394=m CONFIG_ADB_PMU=y CONFIG_PMAC_SMU=y CONFIG_THERM_PM72=y @@ -223,43 +211,49 @@ CONFIG_WINDFARM_PM81=y CONFIG_WINDFARM_PM91=y CONFIG_WINDFARM_PM112=y CONFIG_WINDFARM_PM121=y -CONFIG_NETDEVICES=y CONFIG_DUMMY=m CONFIG_BONDING=m CONFIG_TUN=m CONFIG_MARVELL_PHY=y CONFIG_BROADCOM_PHY=m -CONFIG_NET_ETHERNET=y -CONFIG_SUNGEM=y CONFIG_NET_VENDOR_3COM=y CONFIG_VORTEX=y -CONFIG_IBMVETH=m -CONFIG_NET_PCI=y -CONFIG_PCNET32=y -CONFIG_E100=y +CONFIG_NET_VENDOR_ALTEON=y CONFIG_ACENIC=m CONFIG_ACENIC_OMIT_TIGON_I=y -CONFIG_E1000=y -CONFIG_E1000E=y +CONFIG_NET_VENDOR_AMD=y +CONFIG_PCNET32=y CONFIG_TIGON3=y -CONFIG_BNX2=m -CONFIG_SPIDER_NET=m -CONFIG_GELIC_NET=m -CONFIG_GELIC_WIRELESS=y CONFIG_CHELSIO_T1=m -CONFIG_CHELSIO_T3=m -CONFIG_CHELSIO_T4=m +CONFIG_NET_VENDOR_EMULEX=y +CONFIG_BE2NET=m +CONFIG_NET_VENDOR_EXAR=y +CONFIG_S2IO=m +CONFIG_NET_VENDOR_IBM=y +CONFIG_IBMVETH=m +CONFIG_ISERIES_VETH=m CONFIG_EHEA=m -CONFIG_IXGBE=m +CONFIG_NET_VENDOR_INTEL=y +CONFIG_E100=y +CONFIG_E1000=y +CONFIG_E1000E=y CONFIG_IXGB=m -CONFIG_S2IO=m +CONFIG_IXGBE=m +CONFIG_MLX4_EN=m +CONFIG_NET_VENDOR_MYRI=y CONFIG_MYRI10GE=m -CONFIG_NETXEN_NIC=m +CONFIG_NET_VENDOR_NVIDIA=y +CONFIG_NET_VENDOR_PASEMI=y CONFIG_PASEMI_MAC=y -CONFIG_MLX4_EN=m +CONFIG_NET_VENDOR_QLOGIC=y CONFIG_QLGE=m -CONFIG_BE2NET=m -CONFIG_ISERIES_VETH=m +CONFIG_NETXEN_NIC=m +CONFIG_NET_VENDOR_SUN=y +CONFIG_SUNGEM=y +CONFIG_NET_VENDOR_TOSHIBA=y +CONFIG_GELIC_NET=m +CONFIG_GELIC_WIRELESS=y +CONFIG_SPIDER_NET=m CONFIG_PPP=m CONFIG_PPP_ASYNC=m CONFIG_PPP_SYNC_TTY=m @@ -331,7 +325,6 @@ CONFIG_USB=y CONFIG_USB_DEVICEFS=y CONFIG_USB_MON=m CONFIG_USB_EHCI_HCD=y -CONFIG_USB_EHCI_TT_NEWSCHED=y # CONFIG_USB_EHCI_HCD_PPC_OF is not set CONFIG_USB_OHCI_HCD=y CONFIG_USB_STORAGE=m @@ -373,11 +366,9 @@ CONFIG_JFS_POSIX_ACL=y CONFIG_JFS_SECURITY=y CONFIG_XFS_FS=m CONFIG_XFS_POSIX_ACL=y -CONFIG_OCFS2_FS=m CONFIG_BTRFS_FS=m CONFIG_BTRFS_FS_POSIX_ACL=y CONFIG_NILFS2_FS=m -CONFIG_INOTIFY=y CONFIG_AUTOFS4_FS=m CONFIG_FUSE_FS=m CONFIG_ISO9660_FS=y @@ -398,7 +389,6 @@ CONFIG_ROOT_NFS=y CONFIG_NFSD=m CONFIG_NFSD_V3_ACL=y CONFIG_NFSD_V4=y -CONFIG_RPCSEC_GSS_SPKM3=m CONFIG_CIFS=m CONFIG_CIFS_XATTR=y CONFIG_CIFS_POSIX=y @@ -444,15 +434,13 @@ CONFIG_CRC_T10DIF=y CONFIG_MAGIC_SYSRQ=y CONFIG_DEBUG_KERNEL=y CONFIG_LOCKUP_DETECTOR=y -CONFIG_DETECT_HUNG_TASK=y CONFIG_DEBUG_MUTEXES=y -# CONFIG_RCU_CPU_STALL_DETECTOR is not set +CONFIG_DEBUG_STACK_USAGE=y CONFIG_LATENCYTOP=y CONFIG_SYSCTL_SYSCALL_CHECK=y CONFIG_SCHED_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y CONFIG_DEBUG_STACKOVERFLOW=y -CONFIG_DEBUG_STACK_USAGE=y CONFIG_CODE_PATCHING_SELFTEST=y CONFIG_FTR_FIXUP_SELFTEST=y CONFIG_MSI_BITMAP_SELFTEST=y @@ -463,10 +451,8 @@ CONFIG_CRYPTO_NULL=m CONFIG_CRYPTO_TEST=m CONFIG_CRYPTO_CCM=m CONFIG_CRYPTO_GCM=m -CONFIG_CRYPTO_ECB=m CONFIG_CRYPTO_PCBC=m CONFIG_CRYPTO_HMAC=y -CONFIG_CRYPTO_MD4=m CONFIG_CRYPTO_MICHAEL_MIC=m CONFIG_CRYPTO_SHA256=m CONFIG_CRYPTO_SHA512=m @@ -474,7 +460,6 @@ CONFIG_CRYPTO_TGR192=m CONFIG_CRYPTO_WP512=m CONFIG_CRYPTO_AES=m CONFIG_CRYPTO_ANUBIS=m -CONFIG_CRYPTO_ARC4=m CONFIG_CRYPTO_BLOWFISH=m CONFIG_CRYPTO_CAST6=m CONFIG_CRYPTO_KHAZAD=m -- 1.7.5.4 -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-22 1:30 ` Stephen Rothwell @ 2011-08-23 1:40 ` Stephen Rothwell 2011-08-23 1:41 ` Stephen Rothwell 0 siblings, 1 reply; 19+ messages in thread From: Stephen Rothwell @ 2011-08-23 1:40 UTC (permalink / raw) To: David Miller Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher, mikey, torvalds, akpm, ppc-dev, Benjamin Herrenschmidt, Paul Mackerras Hi Dave, On Mon, 22 Aug 2011 11:30:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Here's what I am applying as a merge fixup to the net tree today so that > my ppc64_defconfig builds actually build more or less the same set of > drivers as before this rearrangement. And this today: From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Tue, 23 Aug 2011 11:23:40 +1000 Subject: [PATCH] sparc: update sparc32_defconfig for net device movement Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- arch/sparc/configs/sparc32_defconfig | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/sparc/configs/sparc32_defconfig b/arch/sparc/configs/sparc32_defconfig index fb23fd6..9bc241a 100644 --- a/arch/sparc/configs/sparc32_defconfig +++ b/arch/sparc/configs/sparc32_defconfig @@ -2,9 +2,7 @@ CONFIG_EXPERIMENTAL=y CONFIG_SYSVIPC=y CONFIG_POSIX_MQUEUE=y CONFIG_LOG_BUF_SHIFT=14 -CONFIG_SYSFS_DEPRECATED_V2=y CONFIG_BLK_DEV_INITRD=y -# CONFIG_CC_OPTIMIZE_FOR_SIZE is not set CONFIG_SLAB=y CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y @@ -42,9 +40,10 @@ CONFIG_SCSI_QLOGICPTI=m CONFIG_SCSI_SUNESP=y CONFIG_NETDEVICES=y CONFIG_DUMMY=m -CONFIG_NET_ETHERNET=y CONFIG_MII=m +CONFIG_NET_VENDOR_AMD=y CONFIG_SUNLANCE=y +CONFIG_NET_VENDOR_SUN=y CONFIG_HAPPYMEAL=m CONFIG_SUNBMAC=m CONFIG_SUNQE=m @@ -64,26 +63,22 @@ CONFIG_SERIAL_SUNSU=y CONFIG_SERIAL_SUNSU_CONSOLE=y CONFIG_SPI=y CONFIG_SPI_XILINX=m -CONFIG_SPI_XILINX_PLTFM=m CONFIG_SUN_OPENPROMIO=m CONFIG_EXT2_FS=y CONFIG_EXT2_FS_XATTR=y CONFIG_EXT2_FS_POSIX_ACL=y CONFIG_EXT2_FS_SECURITY=y -CONFIG_AUTOFS_FS=m CONFIG_AUTOFS4_FS=m CONFIG_ISO9660_FS=m CONFIG_PROC_KCORE=y CONFIG_ROMFS_FS=m CONFIG_NFS_FS=y CONFIG_ROOT_NFS=y -CONFIG_RPCSEC_GSS_KRB5=m CONFIG_NLS=y # CONFIG_ENABLE_WARN_DEPRECATED is not set CONFIG_DEBUG_KERNEL=y CONFIG_DETECT_HUNG_TASK=y # CONFIG_SCHED_DEBUG is not set -# CONFIG_RCU_CPU_STALL_DETECTOR is not set CONFIG_KGDB=y CONFIG_KGDB_TESTS=y CONFIG_CRYPTO_NULL=m -- 1.7.5.4 -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-23 1:40 ` Stephen Rothwell @ 2011-08-23 1:41 ` Stephen Rothwell 2011-08-23 2:13 ` David Miller 0 siblings, 1 reply; 19+ messages in thread From: Stephen Rothwell @ 2011-08-23 1:41 UTC (permalink / raw) To: David Miller Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher, mikey, torvalds, akpm, ppc-dev, Benjamin Herrenschmidt, Paul Mackerras Hi Dave, On Tue, 23 Aug 2011 11:40:11 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Mon, 22 Aug 2011 11:30:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > Here's what I am applying as a merge fixup to the net tree today so that > > my ppc64_defconfig builds actually build more or less the same set of > > drivers as before this rearrangement. > > And this today: And this: From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Tue, 23 Aug 2011 11:35:18 +1000 Subject: [PATCH] sparc: update sparc64_defconfig for net device movement Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- arch/sparc/configs/sparc64_defconfig | 20 +++++++++----------- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/arch/sparc/configs/sparc64_defconfig b/arch/sparc/configs/sparc64_defconfig index 3c1e858..5732728 100644 --- a/arch/sparc/configs/sparc64_defconfig +++ b/arch/sparc/configs/sparc64_defconfig @@ -37,8 +37,6 @@ CONFIG_NET_KEY_MIGRATE=y CONFIG_INET=y CONFIG_IP_MULTICAST=y CONFIG_NET_IPIP=m -CONFIG_NET_IPGRE=m -CONFIG_NET_IPGRE_BROADCAST=y CONFIG_IP_MROUTE=y CONFIG_IP_PIMSM_V1=y CONFIG_IP_PIMSM_V2=y @@ -95,17 +93,19 @@ CONFIG_DM_SNAPSHOT=m CONFIG_DM_MIRROR=m CONFIG_DM_ZERO=m CONFIG_NETDEVICES=y -CONFIG_NET_ETHERNET=y CONFIG_MII=m +CONFIG_NET_VENDOR_AMD=y CONFIG_SUNLANCE=m +CONFIG_NET_VENDOR_BROADCOM=y +CONFIG_BNX2=m +CONFIG_TIGON3=m +CONFIG_NET_VENDOR_INTEL=y +CONFIG_E1000=m +CONFIG_E1000E=m +CONFIG_NET_VENDOR_SUN=y CONFIG_HAPPYMEAL=m CONFIG_SUNGEM=m CONFIG_SUNVNET=m -CONFIG_NET_PCI=y -CONFIG_E1000=m -CONFIG_E1000E=m -CONFIG_TIGON3=m -CONFIG_BNX2=m CONFIG_NIU=m # CONFIG_WLAN is not set CONFIG_PPP=m @@ -126,13 +126,13 @@ CONFIG_INPUT_SPARCSPKR=y # CONFIG_SERIO_SERPORT is not set CONFIG_SERIO_PCIPS2=m CONFIG_SERIO_RAW=m +# CONFIG_LEGACY_PTYS is not set # CONFIG_DEVKMEM is not set CONFIG_SERIAL_SUNSU=y CONFIG_SERIAL_SUNSU_CONSOLE=y CONFIG_SERIAL_SUNSAB=y CONFIG_SERIAL_SUNSAB_CONSOLE=y CONFIG_SERIAL_SUNHV=y -# CONFIG_LEGACY_PTYS is not set CONFIG_FB=y CONFIG_FB_TILEBLITTING=y CONFIG_FB_SBUS=y @@ -206,10 +206,8 @@ CONFIG_PRINTK_TIME=y CONFIG_MAGIC_SYSRQ=y CONFIG_DEBUG_KERNEL=y CONFIG_LOCKUP_DETECTOR=y -CONFIG_DETECT_HUNG_TASK=y # CONFIG_SCHED_DEBUG is not set CONFIG_SCHEDSTATS=y -# CONFIG_RCU_CPU_STALL_DETECTOR is not set CONFIG_SYSCTL_SYSCALL_CHECK=y CONFIG_BLK_DEV_IO_TRACE=y CONFIG_KEYS=y -- 1.7.5.4 -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-23 1:41 ` Stephen Rothwell @ 2011-08-23 2:13 ` David Miller 2011-08-23 2:26 ` Jeff Kirsher 2011-08-23 3:50 ` Arnaud Lacombe 0 siblings, 2 replies; 19+ messages in thread From: David Miller @ 2011-08-23 2:13 UTC (permalink / raw) To: sfr Cc: netdev, linux-next, linux-kernel, jeffrey.t.kirsher, mikey, torvalds, akpm, linuxppc-dev, benh, paulus From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Tue, 23 Aug 2011 11:41:29 +1000 > On Tue, 23 Aug 2011 11:40:11 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> >> On Mon, 22 Aug 2011 11:30:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> > >> > Here's what I am applying as a merge fixup to the net tree today so that >> > my ppc64_defconfig builds actually build more or less the same set of >> > drivers as before this rearrangement. >> >> And this today: > > And this: I'm starting to get uncomfortable with this whole situation, and I feel more and more that these new kconfig guards are not tenable. Changing defconfig files might fix the "automated test boot with defconfig" case but it won't fix the case of someone trying to automate a build and boot using a different, existing, config file. It ought to work too, and I do know people really do this. And just the fact that we would have to merge all of these defconfig changes through the networking tree is evidence of how it's really not reasonable to be doing things this way. Jeff, I think we need to revert the dependencies back to what they were before the drivers/net moves. Could you prepare a patch which does that? ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-23 2:13 ` David Miller @ 2011-08-23 2:26 ` Jeff Kirsher 2011-08-23 3:50 ` Arnaud Lacombe 1 sibling, 0 replies; 19+ messages in thread From: Jeff Kirsher @ 2011-08-23 2:26 UTC (permalink / raw) To: David Miller Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, mikey@neuling.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org, paulus@samba.org [-- Attachment #1: Type: text/plain, Size: 1586 bytes --] On Mon, 2011-08-22 at 19:13 -0700, David Miller wrote: > From: Stephen Rothwell <sfr@canb.auug.org.au> > Date: Tue, 23 Aug 2011 11:41:29 +1000 > > > On Tue, 23 Aug 2011 11:40:11 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > >> > >> On Mon, 22 Aug 2011 11:30:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > >> > > >> > Here's what I am applying as a merge fixup to the net tree today so that > >> > my ppc64_defconfig builds actually build more or less the same set of > >> > drivers as before this rearrangement. > >> > >> And this today: > > > > And this: > > I'm starting to get uncomfortable with this whole situation, and I > feel more and more that these new kconfig guards are not tenable. > > Changing defconfig files might fix the "automated test boot with > defconfig" case but it won't fix the case of someone trying to > automate a build and boot using a different, existing, config file. > It ought to work too, and I do know people really do this. > > And just the fact that we would have to merge all of these defconfig changes > through the networking tree is evidence of how it's really not reasonable > to be doing things this way. > > Jeff, I think we need to revert the dependencies back to what they were > before the drivers/net moves. Could you prepare a patch which does that? > I was just finishing up those patches (not including any defconfig changes) and started looking at a patch to fix/resolve the issues that Stephen is seeing. Let me see what I can come up with tonight to resolve this. [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-23 2:13 ` David Miller 2011-08-23 2:26 ` Jeff Kirsher @ 2011-08-23 3:50 ` Arnaud Lacombe 2011-08-23 4:02 ` David Miller 1 sibling, 1 reply; 19+ messages in thread From: Arnaud Lacombe @ 2011-08-23 3:50 UTC (permalink / raw) To: David Miller Cc: sfr, netdev, linux-next, linux-kernel, jeffrey.t.kirsher, mikey, torvalds, akpm, linuxppc-dev, benh, paulus, linux-kbuild Hi, [Added linux-kbuild@ to the Cc: list.] On Mon, Aug 22, 2011 at 10:13 PM, David Miller <davem@davemloft.net> wrote: > From: Stephen Rothwell <sfr@canb.auug.org.au> > Date: Tue, 23 Aug 2011 11:41:29 +1000 > >> On Tue, 23 Aug 2011 11:40:11 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >>> >>> On Mon, 22 Aug 2011 11:30:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >>> > >>> > Here's what I am applying as a merge fixup to the net tree today so that >>> > my ppc64_defconfig builds actually build more or less the same set of >>> > drivers as before this rearrangement. >>> >>> And this today: >> >> And this: > > I'm starting to get uncomfortable with this whole situation, and I > feel more and more that these new kconfig guards are not tenable. > > Changing defconfig files might fix the "automated test boot with > defconfig" case but it won't fix the case of someone trying to > automate a build and boot using a different, existing, config file. > It ought to work too, and I do know people really do this. > > And just the fact that we would have to merge all of these defconfig changes > through the networking tree is evidence of how it's really not reasonable > to be doing things this way. > > Jeff, I think we need to revert the dependencies back to what they were > before the drivers/net moves. Could you prepare a patch which does that? > Are you implying we need some kind of way to migrate config ? - Arnaud -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-23 3:50 ` Arnaud Lacombe @ 2011-08-23 4:02 ` David Miller 2011-08-23 8:29 ` Jeff Kirsher 0 siblings, 1 reply; 19+ messages in thread From: David Miller @ 2011-08-23 4:02 UTC (permalink / raw) To: lacombar Cc: sfr, netdev, linux-next, linux-kernel, jeffrey.t.kirsher, mikey, torvalds, akpm, linuxppc-dev, benh, paulus, linux-kbuild From: Arnaud Lacombe <lacombar@gmail.com> Date: Mon, 22 Aug 2011 23:50:02 -0400 > Are you implying we need some kind of way to migrate config ? The issue is that the dependencies for every single ethernet driver have changed. Some dependencies have been dropped (f.e. NETDEV_10000 and some have been added (f.e. ETHERNET, NET_VENDOR_****) So right now an automated (non-prompted, default to no on all new options) run on an existing config results in all ethernet drivers getting disabled because the new dependencies don't get enabled. This wouldn't be so bad if it was just one or two drivers, but in this case it's every single ethernet driver which will have and hit this problem. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: boot test failure (net tree) 2011-08-23 4:02 ` David Miller @ 2011-08-23 8:29 ` Jeff Kirsher 0 siblings, 0 replies; 19+ messages in thread From: Jeff Kirsher @ 2011-08-23 8:29 UTC (permalink / raw) To: David Miller Cc: lacombar@gmail.com, sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, mikey@neuling.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org, paulus@samba.org, linux-kbuild@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 1358 bytes --] On Mon, 2011-08-22 at 21:02 -0700, David Miller wrote: > From: Arnaud Lacombe <lacombar@gmail.com> > Date: Mon, 22 Aug 2011 23:50:02 -0400 > > > Are you implying we need some kind of way to migrate config ? > > The issue is that the dependencies for every single ethernet driver > have changed. Some dependencies have been dropped (f.e. NETDEV_10000 > and some have been added (f.e. ETHERNET, NET_VENDOR_****) > > So right now an automated (non-prompted, default to no on all new > options) run on an existing config results in all ethernet drivers > getting disabled because the new dependencies don't get enabled. > > This wouldn't be so bad if it was just one or two drivers, but in > this case it's every single ethernet driver which will have and hit > this problem. > Ok, I have patch which will resolve the issue. It is the last patch in the series I am about to send out. What this patch does is set the "new" Kconfig options to Y, so that current defconfig's can build driver's that are currently set to build. This will fix the issue, I have confirmed this with the x86_64 defconfig. It will be nice that eventually all configs get updated so that not all the NET_VENDOR_* tags have to be enabled, but understandably this is the best way to ensure that current defconfig's will compile all expected drivers. [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2011-08-23 8:29 UTC | newest] Thread overview: 19+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-08-17 0:01 linux-next: boot test failure (net tree) Stephen Rothwell 2011-08-17 0:15 ` David Miller 2011-08-17 0:50 ` Stephen Rothwell 2011-08-17 0:56 ` David Miller 2011-08-17 1:19 ` Ben Hutchings 2011-08-17 3:04 ` David Miller 2011-08-17 1:21 ` Stephen Rothwell 2011-08-17 3:05 ` David Miller 2011-08-18 5:22 ` Stephen Rothwell 2011-08-18 5:40 ` Jeff Kirsher 2011-08-18 5:53 ` David Miller 2011-08-22 1:30 ` Stephen Rothwell 2011-08-23 1:40 ` Stephen Rothwell 2011-08-23 1:41 ` Stephen Rothwell 2011-08-23 2:13 ` David Miller 2011-08-23 2:26 ` Jeff Kirsher 2011-08-23 3:50 ` Arnaud Lacombe 2011-08-23 4:02 ` David Miller 2011-08-23 8:29 ` Jeff Kirsher
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).