Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features

Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features

[Ben Greear]

On 06/22/2011 09:04 AM, Michał Mirosław wrote:
> v3 of a feature handling cleanup and extension series. For testing, you
> might want user-space ethtool patched with:
>
> http://patchwork.ozlabs.org/patch/96374/

There is a typo in one of those patches:

   CC      fs/quota/netlink.o
/home/greearb/git/net-next-2.6/net/core/dev.c: In function ‘__netdev_update_features’:
/home/greearb/git/net-next-2.6/net/core/dev.c:5288: warning: too many arguments for format
   CC      net/core/ethtool.o

	netdev_dbg(dev, "Features changed: %pNF -> pNF\n",
		&dev->features, &features);

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features

[Michał Mirosław]

On Wed, Jun 22, 2011 at 04:11:28PM -0700, Ben Greear wrote:
> On 06/22/2011 09:04 AM, Michał Mirosław wrote:
> >v3 of a feature handling cleanup and extension series. For testing, you
> >might want user-space ethtool patched with:
> >
> >http://patchwork.ozlabs.org/patch/96374/
> There is a typo in one of those patches:
>   CC      fs/quota/netlink.o
> /home/greearb/git/net-next-2.6/net/core/dev.c: In function ‘__netdev_update_features’:
> /home/greearb/git/net-next-2.6/net/core/dev.c:5288: warning: too many arguments for format
>   CC      net/core/ethtool.o
> 	netdev_dbg(dev, "Features changed: %pNF -> pNF\n",
> 		&dev->features, &features);

Noted for next version.

Best Regards,
Michał Mirosław 

Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features

[Ben Greear]

On 06/22/2011 09:04 AM, Michał Mirosław wrote:
> v3 of a feature handling cleanup and extension series. For testing, you
> might want user-space ethtool patched with:
>
> http://patchwork.ozlabs.org/patch/96374/

It looks like this is not in net-next yet...any hope of this
going in soon?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features

[David Miller]

From: Ben Greear <greearb@candelatech.com>
Date: Thu, 25 Aug 2011 12:04:40 -0700

> On 06/22/2011 09:04 AM, Michał Mirosław wrote:
>> v3 of a feature handling cleanup and extension series. For testing,
>> you
>> might want user-space ethtool patched with:
>>
>> http://patchwork.ozlabs.org/patch/96374/
> 
> It looks like this is not in net-next yet...any hope of this
> going in soon?

Why would it go into net-next?  It's not a kernel patch, it's a patch
for the ethool userland utility.

Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features

[Ben Greear]

On 08/26/2011 09:41 AM, David Miller wrote:
> From: Ben Greear<greearb@candelatech.com>
> Date: Thu, 25 Aug 2011 12:04:40 -0700
> 
>> On 06/22/2011 09:04 AM, Michał Mirosław wrote:
>>> v3 of a feature handling cleanup and extension series. For testing,
>>> you
>>> might want user-space ethtool patched with:
>>>
>>> http://patchwork.ozlabs.org/patch/96374/
>>
>> It looks like this is not in net-next yet...any hope of this
>> going in soon?
> 
> Why would it go into net-next?  It's not a kernel patch, it's a patch
> for the ethool userland utility.

I meant the kernel bits in that patch series, not the link.

Sorry for not snipping enough.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features

[David Miller]

From: Ben Greear <greearb@candelatech.com>
Date: Fri, 26 Aug 2011 09:43:19 -0700

> On 08/26/2011 09:41 AM, David Miller wrote:
>> From: Ben Greear<greearb@candelatech.com>
>> Date: Thu, 25 Aug 2011 12:04:40 -0700
>> 
>>> On 06/22/2011 09:04 AM, Michał Mirosław wrote:
>>>> v3 of a feature handling cleanup and extension series. For testing,
>>>> you
>>>> might want user-space ethtool patched with:
>>>>
>>>> http://patchwork.ozlabs.org/patch/96374/
>>>
>>> It looks like this is not in net-next yet...any hope of this
>>> going in soon?
>> 
>> Why would it go into net-next?  It's not a kernel patch, it's a patch
>> for the ethool userland utility.
> 
> I meant the kernel bits in that patch series, not the link.

It's possible that if you go look at the threads about those kernel
patches you're find out the reason.

Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features

[Michał Mirosław]

On Thu, Aug 25, 2011 at 12:04:40PM -0700, Ben Greear wrote:
> On 06/22/2011 09:04 AM, Michał Mirosław wrote:
> >v3 of a feature handling cleanup and extension series. For testing, you
> >might want user-space ethtool patched with:
> >http://patchwork.ozlabs.org/patch/96374/
> It looks like this is not in net-next yet...any hope of this
> going in soon?

It's because the series depends on finishing conversions of all drivers
to ndo_fix/set_features. e1000e, igbvf, ixgb, ixgbevf are pending.

BTW, Jeff, what is the status of those conversions? Last version of ixgbe
patch from Donald Skidmore (sent about a month ago) was mostly ready IIUC.

Best Regards,
Michał Mirosław

Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

On Fri, 2011-08-26 at 11:41 -0700, Michał Mirosław wrote:
> On Thu, Aug 25, 2011 at 12:04:40PM -0700, Ben Greear wrote:
> > On 06/22/2011 09:04 AM, Michał Mirosław wrote:
> > >v3 of a feature handling cleanup and extension series. For testing, you
> > >might want user-space ethtool patched with:
> > >http://patchwork.ozlabs.org/patch/96374/
> > It looks like this is not in net-next yet...any hope of this
> > going in soon?
> 
> It's because the series depends on finishing conversions of all drivers
> to ndo_fix/set_features. e1000e, igbvf, ixgb, ixgbevf are pending.
> 
> BTW, Jeff, what is the status of those conversions? Last version of ixgbe
> patch from Donald Skidmore (sent about a month ago) was mostly ready IIUC.
> 
> Best Regards,
> Michał Mirosław

e1000e patch just completed testing, I will be pushing that tonight.
ixgbe got pushed back in June, but there some suggested changes you had
made with Don and that patch has been in/out of testing due to issues
found.  

It also appears that the ixgbevf patch has completed testing.  The only
remaining patch which is left to complete is igbvf.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]