From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch 1/2] 9p: move dereference after NULL check Date: Fri, 26 Aug 2011 19:55:59 +0300 Message-ID: <20110826165559.GE3775@shale.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Venkateswararao Jujjuri , "Aneesh Kumar K.V" , "M. Mohan Kumar" , "open list:NETWORKING [GENERAL]" , kernel-janitors@vger.kernel.org To: Eric Van Hensbergen Return-path: Received: from mail-qy0-f181.google.com ([209.85.216.181]:51036 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032Ab1HZQ6T (ORCPT ); Fri, 26 Aug 2011 12:58:19 -0400 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: We dereferenced "req->tc" and "req->rc" before checking for NULL. Signed-off-by: Dan Carpenter diff --git a/net/9p/client.c b/net/9p/client.c index 3f8c046..b0bcace 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -248,10 +248,8 @@ static struct p9_req_t *p9_tag_alloc(struct p9_client *c, u16 tag, int max_size) init_waitqueue_head(req->wq); req->tc = kmalloc(sizeof(struct p9_fcall) + alloc_msize, GFP_NOFS); - req->tc->capacity = alloc_msize; req->rc = kmalloc(sizeof(struct p9_fcall) + alloc_msize, GFP_NOFS); - req->rc->capacity = alloc_msize; if ((!req->tc) || (!req->rc)) { printk(KERN_ERR "Couldn't grow tag array\n"); kfree(req->tc); @@ -261,6 +259,8 @@ static struct p9_req_t *p9_tag_alloc(struct p9_client *c, u16 tag, int max_size) req->wq = NULL; return ERR_PTR(-ENOMEM); } + req->tc->capacity = alloc_msize; + req->rc->capacity = alloc_msize; req->tc->sdata = (char *) req->tc + sizeof(struct p9_fcall); req->rc->sdata = (char *) req->rc + sizeof(struct p9_fcall); }