From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: akpm@linux-foundation.org, sjur.brandeland@stericsson.com,
linux-kernel@vger.kernel.org, eric.dumazet@gmail.com,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH] caif: Remove OOM messages, use kzalloc
Date: Sun, 28 Aug 2011 17:16:28 -0400 (EDT) [thread overview]
Message-ID: <20110828.171628.554738440008982339.davem@davemloft.net> (raw)
In-Reply-To: <1314314545.4637.19.camel@Joe-Laptop>
From: Joe Perches <joe@perches.com>
Date: Thu, 25 Aug 2011 16:22:24 -0700
> Remove per site OOM messages because they duplicate
> the generic mm subsystem OOM message.
>
> Use kzalloc instead of kmalloc/memset
> when next to the OOM message removals.
>
> Reduces object size (allyesconfig ~2%)
>
> $ size -t drivers/net/caif/built-in.o.old net/caif/built-in.o.old
> text data bss dec hex filename
> 32297 700 8224 41221 a105 drivers/net/caif/built-in.o.old
> 72159 1317 20552 94028 16f4c net/caif/built-in.o.old
> 104456 2017 28776 135249 21051 (TOTALS)
> $ size -t drivers/net/caif/built-in.o.new net/caif/built-in.o.new
> text data bss dec hex filename
> 31975 700 8184 40859 9f9b drivers/net/caif/built-in.o.new
> 70748 1317 20152 92217 16839 net/caif/built-in.o.new
> 102723 2017 28336 133076 207d4 (TOTALS)
>
> Signed-off-by: Joe Perches <joe@perches.com>
Looks good to me, applied, thanks Joe.
prev parent reply other threads:[~2011-08-28 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 20:47 RFC: Remove unnecessary / duplicate OOM printks Joe Perches
2011-08-25 22:04 ` Andrew Morton
2011-08-25 23:22 ` [RFC PATCH] caif: Remove OOM messages, use kzalloc Joe Perches
2011-08-28 21:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110828.171628.554738440008982339.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).