From: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Greg Dietsche <gregory.dietsche-5+R7UueiBCQ@public.gmane.org>
Cc: linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] iwlegacy: change IWL_WARN to IWL_DEBUG_HT in iwl4965_tx_agg_start
Date: Mon, 29 Aug 2011 16:00:36 +0200 [thread overview]
Message-ID: <20110829140032.GA1573@redhat.com> (raw)
In-Reply-To: <4E5B9533.6000109-5+R7UueiBCQ@public.gmane.org>
Hi Greg
On Mon, Aug 29, 2011 at 08:33:39AM -0500, Greg Dietsche wrote:
> On 08/29/2011 07:20 AM, Stanislaw Gruszka wrote:
> >On Sun, Aug 28, 2011 at 08:26:16AM -0500, Greg Dietsche wrote:
> >>This message should be a debug message and not a warning. So
> >>change it from IWL_WARN to IWL_DEBUG_HT.
> >I'm currently doing massive iwlegacy driver cleanup. Would be easier
> >for me to apply these patches on top of my changes instead of rebase
> >my patches. I will queue these two patches and post them together with
> >my pending patches.
> >
> That sounds good to me. I have the 4065 card in my laptop and want
> to learn how it works. If you want someone to test your changes, I'm
> willing.
>
> I have six other patches that are trivial in nature for the iwlegacy
> driver. One of those also applies to the iwlagn driver, so seven
> patches in total. They remove some null checks that aren't necessary
> and also cleanup a few unused variables. There are two patches in
> the set that I'm not 100% sure about. They remove null checks and I
> haven't been able to prove to myself that they are correct. However,
> if they aren't correct, then there are some null checks in other
> places that need to be added....
>
> Anyway, I can hold off on these until you've done your cleanup and
> see what still applies,
That would be great.
> or if you have a tree someplace, I'd be
> happy to rebase them for you.
I do not have publicly available tree. I'll probably try to get
one on git.kernel.org. I will let you know.
Thanks,
Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-29 14:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-28 13:26 [PATCH 1/2] iwlegacy: change IWL_WARN to IWL_DEBUG_HT in iwl4965_tx_agg_start Greg Dietsche
2011-08-28 13:26 ` [PATCH 2/2] iwlegacy: change IWL_WARN to IWL_DEBUG_HT in iwl4965_rs_tl_turn_on_agg_for_tid Greg Dietsche
[not found] ` <1314537977-20097-2-git-send-email-Gregory.Dietsche-5+R7UueiBCQ@public.gmane.org>
2011-08-28 13:32 ` [PATCH 2/2 v2] iwlegacy: change IWL_ERR " y
[not found] ` <1314537977-20097-1-git-send-email-Gregory.Dietsche-5+R7UueiBCQ@public.gmane.org>
2011-08-29 12:20 ` [PATCH 1/2] iwlegacy: change IWL_WARN to IWL_DEBUG_HT in iwl4965_tx_agg_start Stanislaw Gruszka
2011-08-29 13:33 ` Greg Dietsche
[not found] ` <4E5B9533.6000109-5+R7UueiBCQ@public.gmane.org>
2011-08-29 14:00 ` Stanislaw Gruszka [this message]
2011-09-06 15:01 ` Stanislaw Gruszka
2011-09-08 3:51 ` Greg Dietsche
2011-09-08 16:11 ` Stanislaw Gruszka
2011-09-18 14:41 ` Greg Dietsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110829140032.GA1573@redhat.com \
--to=sgruszka-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=gregory.dietsche-5+R7UueiBCQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).