From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next-2.6 1/2] net: allow to change carrier via sysfs Date: Wed, 31 Aug 2011 10:45:12 +0200 Message-ID: <20110831084511.GD2010@minipsycho.brq.redhat.com> References: <1314715608-978-1-git-send-email-jpirko@redhat.com> <1314715608-978-2-git-send-email-jpirko@redhat.com> <20110831082655.GB2010@minipsycho.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org, davem@davemloft.net, eric.dumazet@gmail.com, bhutchings@solarflare.com, shemminger@vyatta.com To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15965 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779Ab1HaIpR (ORCPT ); Wed, 31 Aug 2011 04:45:17 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Wed, Aug 31, 2011 at 10:33:50AM CEST, mirqus@gmail.com wrote: >W dniu 31 sierpnia 2011 10:26 u=C5=BCytkownik Jiri Pirko napisa=C5=82: >> Tue, Aug 30, 2011 at 08:11:37PM CEST, mirqus@gmail.com wrote: >>>2011/8/30 Jiri Pirko : >>>> Allow to write to "carrier" attribute. Devices may implement ndo_c= hange_carrier >>>> callback to allow changing carrier from userspace. >>>Do you expect drivers using implementation different than just calli= ng >>>netif_carrier_on/off? Or is it supposed to also e.g. power down PHYs= ? >> Yes, generally it can be used also for en/disable phy, for testing >> purposes if hw and driver would support it. > >I'd like to see this working for GRE tunnel devices (for keepalive >daemon to be able to indicate to routing daemons whether tunnel is >really working) - implementation would be identical to dummy's case. >Should I prepare a patch or can I leave it to you? Ok, I can include it to this patchset (I'm going to repost first patch anyway) > >Best Regards, >Micha=C5=82 Miros=C5=82aw