netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Dan McGee <dan@archlinux.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] iproute2: fix several warnings emitted by clang scan-build
Date: Wed, 31 Aug 2011 12:20:06 -0700	[thread overview]
Message-ID: <20110831122006.52c958dd@nehalam.ftrdhcpuser.net> (raw)
In-Reply-To: <1310759966-10465-1-git-send-email-dan@archlinux.org>

On Fri, 15 Jul 2011 14:59:26 -0500
Dan McGee <dan@archlinux.org> wrote:

> * genl/genl.c: remove unused basename logic, avoid dereference of
>   possibly NULL variable
> * ip/iptuntap.c: avoid double open and leak of file handle
> * misc/arpd.c: zero out socklen structure
> * misc/{ifstat,nstat,rtacct}.c: ensure uptime is initialized if
>   /proc/uptime cannot be opened
> * tc/m_xt.c: only unset fields if m is non-NULL
> 
> Signed-off-by: Dan McGee <dan@archlinux.org>

All but arpd applied. The arpd change is unnecessary since the
socket structure is in recvfrom() call it will be set by kernel.

      reply	other threads:[~2011-08-31 19:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-15 19:59 [PATCH] iproute2: fix several warnings emitted by clang scan-build Dan McGee
2011-08-31 19:20 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110831122006.52c958dd@nehalam.ftrdhcpuser.net \
    --to=shemminger@vyatta.com \
    --cc=dan@archlinux.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).