From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] bridge: mask forwarding of IEEE 802 local multicast groups Date: Wed, 31 Aug 2011 13:49:04 -0700 Message-ID: <20110831134904.1a050924@nehalam.ftrdhcpuser.net> References: <20110711082755.0b38a15a@nehalam.ftrdhcpuser.net> <20110712113643.GC616804@jupiter.n2.diac24.net> <20110715160357.GC1407585@jupiter.n2.diac24.net> <20110715163345.GD1407585@jupiter.n2.diac24.net> <20110727111714.GA2027462@jupiter.n2.diac24.net> <20110728084106.22166324@nehalam.ftrdhcpuser.net> <20110815112501.3a3c01ad@nehalam.ftrdhcpuser.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Lamparter , eswierk@bigswitch.com, netdev@vger.kernel.org, =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , davem@davemloft.net To: Nick Carter Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:53516 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411Ab1HaUub convert rfc822-to-8bit (ORCPT ); Wed, 31 Aug 2011 16:50:31 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 31 Aug 2011 21:41:26 +0100 Nick Carter wrote: > On 15 August 2011 19:25, Stephen Hemminger > wrote: > > On Mon, 15 Aug 2011 17:27:12 +0100 > > Nick Carter wrote: > > > >> On 28 July 2011 16:41, Stephen Hemminger > >> wrote: > >> > On Wed, 27 Jul 2011 13:17:15 +0200 > >> > David Lamparter wrote: > >> > > >> >> On Fri, Jul 15, 2011 at 06:33:45PM +0200, David Lamparter wrote= : > >> >> > On Fri, Jul 15, 2011 at 06:03:57PM +0200, David Lamparter wro= te: > >> >> > > On Fri, Jul 15, 2011 at 04:44:50PM +0100, Nick Carter wrote= : > >> >> > > > On 12 July 2011 12:36, David Lamparter wrote: > >> >> > > > > On Mon, Jul 11, 2011 at 08:27:55AM -0700, Stephen Hemmi= nger wrote: > >> >> > > > >> I am still undecided on this. Understand the need, but= don't like idea > >> >> > > > >> of bridge behaving in non-conforming manner. Will see = if IEEE 802 committee > >> >> > > > >> has any input. > >> >> > > > > > >> >> > > > > The patch doesn't make the bridge behave nonconformant.= The default mask > >> >> > > > > is 0, which just keeps the old behaviour. > >> >> > > >> >> > P.S.: I'd like to once more stress this. In my opinion the pa= tch should > >> >> > be merged because it provides desireable functionality at a s= mall cost > >> >> > (one test, one knob) and __does not change any default behavi= our__. > >> >> > >> >> Stephen, anything new on this? > >> > > >> > No. > >> > Don't like adding yet another hack user visible API which will h= ave > >> > to be maintained for too long. But on the other hand I don't hav= e > >> > a better solution at my finger tips. If better idea doesn't come > >> > along, then we can go with yours. > >> > > >> I have not noticed any other proposals and this thread has been op= en > >> for quite a while. =A0Have we waited long enough ? If so can this = patch > >> be taken ? > >> > > > > I am testing an alternative. The problem with your proposal is that > > it relies on the multicast address. It turns out there are people u= sing > > other addresses for the STP group address, so using that as a ident= ifier > > is incorrect. > If the chosen STP group address is in the local multicast group range > this patch will handle it. >=20 > David Lamparter has reviewed this patch and asked for it to be merged= =2E > This patch has at least two real world uses. Ed needs this patch to > forward LLDP frames and I need this patch to forward 802.1X frames. >=20 > This patch has been out for review for 9 weeks and it still looks lik= e > the best solution. I prefer the netfilter solution because it is more general. We already = have a firewall solution why shouldn't this case be part of it?