From: David Miller <davem@davemloft.net>
To: carolyn.wyborny@intel.com
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: [RFC, 1/2] ethtool: Implement private flags interface for ethtool application.
Date: Fri, 02 Sep 2011 16:55:24 -0400 (EDT) [thread overview]
Message-ID: <20110902.165524.1076389492712310664.davem@davemloft.net> (raw)
In-Reply-To: <1314996631-4773-1-git-send-email-carolyn.wyborny@intel.com>
From: Carolyn Wyborny <carolyn.wyborny@intel.com>
Date: Fri, 2 Sep 2011 13:50:30 -0700
> This patch completes the user space implementation of the private
> flags inteface in ethtool. Using -b/-B options.
>
> Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
The only use case you show here is something generic which other
chips have, Energy Efficient Ethernet.
Making an attribute private which is present widely amonst various
networking chips makes no sense at all.
It deserved a generic ethtool flag.
next prev parent reply other threads:[~2011-09-02 20:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 20:50 [RFC, 1/2] ethtool: Implement private flags interface for ethtool application Carolyn Wyborny
2011-09-02 20:50 ` [RFC, 2/2] igb: Implementation of ethtool priv_flags for igb driver Carolyn Wyborny
2011-09-02 21:31 ` Ben Hutchings
2011-09-02 20:55 ` David Miller [this message]
2011-09-02 21:11 ` [RFC, 1/2] ethtool: Implement private flags interface for ethtool application Wyborny, Carolyn
2011-09-02 21:17 ` Michał Mirosław
2011-09-02 21:22 ` Michał Mirosław
2011-09-02 21:29 ` Wyborny, Carolyn
2011-09-02 21:34 ` Ben Hutchings
2011-09-02 21:35 ` Wyborny, Carolyn
2011-09-03 1:39 ` Michał Mirosław
2011-09-02 21:23 ` Ben Hutchings
2011-09-02 21:27 ` Ben Hutchings
2011-09-02 21:33 ` Wyborny, Carolyn
2011-09-02 21:36 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902.165524.1076389492712310664.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=carolyn.wyborny@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).