From: Oliver Neukum <oliver@neukum.org>
To: Jim Wylder <jwylder1@motorola.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] usbnet: ignore get interface retval of -EINPROGRESS
Date: Sat, 3 Sep 2011 18:37:48 +0200 [thread overview]
Message-ID: <201109031837.48444.oliver@neukum.org> (raw)
In-Reply-To: <CAPopfEUUaEChuh1mdZnHHT_9uRfsQmwMu7=gjnYr=AmFWik2HA@mail.gmail.com>
Am Samstag, 3. September 2011, 16:21:00 schrieb Jim Wylder:
> When calling pm_runtime_get, usb_autopm_get_interface_async
> treats a return value of -EINPROGRESS as a success and
> increments the usage count. Since the interface is resuming,
> it is safe for usbnet_start_xmit to submit the urb.
usbnet_start_xmit() is exported, so simply stating that it is
called when the interface is resumingisn't enough. It seems to
me that the later check for DEV_ASLEEP will save as, but have
you checked for that?
Regards
Oliver
next prev parent reply other threads:[~2011-09-03 16:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 14:21 [PATCH] usbnet: ignore get interface retval of -EINPROGRESS Jim Wylder
2011-09-03 16:37 ` Oliver Neukum [this message]
2011-09-03 17:32 ` Jim Wylder
2011-09-04 10:16 ` Oliver Neukum
2011-09-05 16:29 ` Jim Wylder
2011-09-05 16:36 ` Jim Wylder
2011-09-06 6:14 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109031837.48444.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=jwylder1@motorola.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).