From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Martin Subject: Re: [PATCH v3] net/smsc911x: add device tree probe support Date: Fri, 9 Sep 2011 09:50:30 +0100 Message-ID: <20110909085030.GA3069@arm.com> References: <1311587040-8988-1-git-send-email-shawn.guo@linaro.org> <1312050360-15767-1-git-send-email-shawn.guo@linaro.org> <20110908145946.GE2070@arm.com> <20110908182920.GL2967@ponder.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Shawn Guo , netdev@vger.kernel.org, patches@linaro.org, devicetree-discuss@lists.ozlabs.org, Steve Glendinning , "David S. Miller" , linux-arm-kernel@lists.infradead.org To: Grant Likely Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:49011 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932827Ab1IIIun (ORCPT ); Fri, 9 Sep 2011 04:50:43 -0400 Received: by wwf5 with SMTP id 5so890110wwf.1 for ; Fri, 09 Sep 2011 01:50:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20110908182920.GL2967@ponder.secretlab.ca> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Sep 08, 2011 at 11:29:20AM -0700, Grant Likely wrote: > On Thu, Sep 08, 2011 at 03:59:46PM +0100, Dave Martin wrote: > > Hi Shawn, > > > > On Sun, Jul 31, 2011 at 02:26:00AM +0800, Shawn Guo wrote: > > > It adds device tree probe support for smsc911x driver. > > > > > > Signed-off-by: Shawn Guo > > > Cc: Grant Likely > > > Cc: Steve Glendinning > > > Cc: David S. Miller > > > Reviewed-by: Grant Likely > > > --- > > > Changes since v2: > > > * Fix a typo in smsc911x.txt > > > > > > Changes since v1: > > > * Instead of getting irq line from gpio number, it use irq domain > > > to keep platform_get_resource(IORESOURCE_IRQ) works for dt too. > > > * Use 'lan9115' the first model that smsc911x supports in the match > > > table > > > * Use reg-shift and reg-io-width which already used in of_serial for > > > shift and access size binding > > > > When using this patch with vexpress, I found that 16-bit register access > > mode doesn't seem to be getting set correctly. > > > > Can you take a look at this additional patch and let me know if it looks > > correct? > > > > Cheers > > ---Dave > > > > From: Dave Martin > > Date: Wed, 7 Sep 2011 17:26:31 +0100 > > Subject: [PATCH] net/smsc911x: Correctly configure 16-bit register access from DT > > > > The SMSC911X_USE_16BIT needs to be set when using 16-bit register > > access. However, currently no flag is set if the DT doesn't specify > > 32-bit access. > > > > This patch should set the SMSC911X_USE_16BIT flag in a manner consistent > > with the documented DT bindings. > > > > Signed-off-by: Dave Martin > > --- > > drivers/net/smsc911x.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c > > index 75c08a5..1a35c25 100644 > > --- a/drivers/net/smsc911x.c > > +++ b/drivers/net/smsc911x.c > > @@ -2121,6 +2121,8 @@ static int __devinit smsc911x_probe_config_dt( > > of_property_read_u32(np, "reg-io-width", &width); > > if (width == 4) > > config->flags |= SMSC911X_USE_32BIT; > > + else > > + config->flags |= SMSC911X_USE_16BIT; > > Would it be better to do "else if (width == 2)"? (completely > uninformed comment. I've not looked at what the non-DT probe path > does on this driver.) I wouldn't have a problem with that. But currently the binding documentation says that any value other than 4, or a missing property, implies 16-bit register access. So the binding documentation would need to change too in that case. Personally I think this would be better, but it's just an opinion. Cheers ---Dave