From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] mac_esp: remove redundant mutual exclusion Date: Sat, 10 Sep 2011 14:28:50 -0400 (EDT) Message-ID: <20110910.142850.1601261425101118430.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-m68k@vger.kernel.org, netdev@vger.kernel.org To: fthain@telegraphics.com.au Return-path: In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Finn Thain Date: Sun, 11 Sep 2011 01:01:34 +1000 (EST) > Mutual exclusion is redundant here because all the paths in the call graph > leading to esp_driver_ops.send_dma_cmd() happen under spin_lock_irqsave/ > spin_lock_irqrestore. Remove it. > > Tested on a Mac Quadra 660av and a Mac LC 630. > > Signed-off-by: Finn Thain This patch should be CC:'d to linux-scsi not netdev I understand how the networking maintainer is very responsive and the SCSI maintainer generally takes forever, so your Freudian slip will go unjudged :-)