From: David Miller <davem@davemloft.net>
To: fthain@telegraphics.com.au
Cc: linux-m68k@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] macmace: disable only the dma interrupt
Date: Sat, 10 Sep 2011 14:30:46 -0400 (EDT) [thread overview]
Message-ID: <20110910.143046.520109083086760748.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1109110042210.5327@nippy.intranet>
From: Finn Thain <fthain@telegraphics.com.au>
Date: Sun, 11 Sep 2011 01:02:16 +1000 (EST)
> Don't disable all interrupts, just disable the relevant one.
>
> Also move a couple of printk calls outside of local_irq_save/restore.
>
> Tested on a Quadra 660av.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Using disable_irq() is very expensive, and when done from an interrupt
handler can deadlock especially on SMP (which I understand might not
be relevant here).
I really can't see why you'd do things this way, especially since
interrupt handlers under Linux now unconditionally always run with cpu
interrupts disabled.
next prev parent reply other threads:[~2011-09-10 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-10 15:02 [PATCH] macmace: disable only the dma interrupt Finn Thain
2011-09-10 18:30 ` David Miller [this message]
2011-09-11 10:02 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110910.143046.520109083086760748.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox