* IRDA: Fix global type conflicts in net/irda/irsysctl.c
@ 2011-09-16 17:32 Andi Kleen
2011-09-16 18:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2011-09-16 17:32 UTC (permalink / raw)
To: samuel, davem, netdev
The externs here didn't agree with the declarations in qos.c.
Better would be probably to move this into a header, but since it's
common practice to have naked externs with sysctls I left it for now.
Cc: samuel@sortiz.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
diff --git a/net/irda/irsysctl.c b/net/irda/irsysctl.c
index d0b70da..be22ad2 100644
--- a/net/irda/irsysctl.c
+++ b/net/irda/irsysctl.c
@@ -40,9 +40,9 @@ extern int sysctl_slot_timeout;
extern int sysctl_fast_poll_increase;
extern char sysctl_devname[];
extern int sysctl_max_baud_rate;
-extern int sysctl_min_tx_turn_time;
-extern int sysctl_max_tx_data_size;
-extern int sysctl_max_tx_window;
+extern unsigned sysctl_min_tx_turn_time;
+extern unsigned sysctl_max_tx_data_size;
+extern unsigned sysctl_max_tx_window;
extern int sysctl_max_noreply_time;
extern int sysctl_warn_noreply_time;
extern int sysctl_lap_keepalive_time;
--
ak@linux.intel.com -- Speaking for myself only
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: IRDA: Fix global type conflicts in net/irda/irsysctl.c
2011-09-16 17:32 IRDA: Fix global type conflicts in net/irda/irsysctl.c Andi Kleen
@ 2011-09-16 18:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-09-16 18:52 UTC (permalink / raw)
To: andi; +Cc: samuel, netdev
Please use "unsigned int" rather than plain "unsigned", and yes
that means you might have to fix up the other instances likewise.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-16 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-16 17:32 IRDA: Fix global type conflicts in net/irda/irsysctl.c Andi Kleen
2011-09-16 18:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).