From: Anton Blanchard <anton@samba.org>
To: David Miller <davem@davemloft.net>
Cc: santil@linux.vnet.ibm.com, brking@linux.vnet.ibm.com,
rcj@linux.vnet.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH 0/4] ibmveth fixes
Date: Sat, 17 Sep 2011 06:51:44 +1000 [thread overview]
Message-ID: <20110917065144.358da241@kryten> (raw)
In-Reply-To: <20110916.152803.861340383634129942.davem@davemloft.net>
Hi Dave,
> All applied.
Thanks!
> I love those "ret1", "ret2", "ret3", "ret4" variables.
>
> Each successive number in the names gives such incredible
> insight into the meaning and usage of the individual
> variables, making it painless for reviewers to understand
> this code.
:) That function needs to be simplified and rewritten, it took me a
while to get my head around it.
Anton
prev parent reply other threads:[~2011-09-16 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 0:41 [PATCH 0/4] ibmveth fixes Anton Blanchard
2011-09-08 0:41 ` [PATCH 1/4] ibmveth: Fix DMA unmap error Anton Blanchard
2011-09-08 0:41 ` [PATCH 2/4] ibmveth: Fix issue with DMA mapping failure Anton Blanchard
2011-09-08 0:41 ` [PATCH 3/4] ibmveth: Checksum offload is always disabled Anton Blanchard
2011-09-08 0:41 ` [PATCH 4/4] ibmveth: Fix checksum offload failure handling Anton Blanchard
2011-09-16 19:28 ` [PATCH 0/4] ibmveth fixes David Miller
2011-09-16 20:51 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110917065144.358da241@kryten \
--to=anton@samba.org \
--cc=brking@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=santil@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).