From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Sasha Levin <levinsasha928@gmail.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] virtio-net: Read MAC only after initializing MSI-X
Date: Mon, 19 Sep 2011 09:01:50 +0300 [thread overview]
Message-ID: <20110919060150.GB1569@redhat.com> (raw)
In-Reply-To: <871uvdryq2.fsf@rustcorp.com.au>
On Mon, Sep 19, 2011 at 01:05:17PM +0930, Rusty Russell wrote:
> On Sat, 20 Aug 2011 23:00:44 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > On Fri, Aug 19, 2011 at 07:33:07PM +0300, Sasha Levin wrote:
> > > Maybe this is better solved by copying the way it was done in PCI itself
> > > with capability linked list?
> >
> > There are any number of ways to lay out the structure. I went for what
> > seemed a simplest one. For MSI-X the train has left the station. We
> > can probably still tweak where the high 32 bit features
> > for 64 bit features are. No idea if it's worth it.
>
> Sorry, this has been in the back of my mind. I think it's a good idea;
> can we use the capability linked list for pre-device specific stuff from
> now on?
>
> Thanks,
> Rusty.
Do we even want capability bits then?
We can give each capability an ack flag ...
--
MST
next prev parent reply other threads:[~2011-09-19 6:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-13 8:51 [PATCH] virtio-net: Read MAC only after initializing MSI-X Sasha Levin
2011-08-14 2:53 ` Rusty Russell
2011-08-14 13:57 ` Sasha Levin
2011-08-15 0:25 ` Rusty Russell
2011-08-15 22:17 ` Sasha Levin
2011-08-19 15:23 ` Michael S. Tsirkin
2011-08-19 16:33 ` Sasha Levin
2011-08-20 20:00 ` Michael S. Tsirkin
2011-09-19 3:35 ` Rusty Russell
2011-09-19 6:01 ` Michael S. Tsirkin [this message]
2011-09-19 7:49 ` Rusty Russell
2011-09-28 18:30 ` Sasha Levin
2011-10-02 9:11 ` Michael S. Tsirkin
2011-10-02 9:09 ` Michael S. Tsirkin
2011-10-03 23:51 ` Rusty Russell
2011-08-22 0:24 ` Rusty Russell
2011-08-22 8:36 ` Michael S. Tsirkin
2011-08-23 3:49 ` Rusty Russell
2011-08-31 16:24 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110919060150.GB1569@redhat.com \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).