From: David Miller <davem@davemloft.net>
To: tanmay.upadhyay@einfochips.com
Cc: ssanap@marvell.com, zgao6@marvell.com, prakity@marvell.com,
markb@marvell.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: pxa168: Fix build errors by including interrupt.h
Date: Tue, 20 Sep 2011 15:47:40 -0400 (EDT) [thread overview]
Message-ID: <20110920.154740.1212490857319716408.davem@davemloft.net> (raw)
In-Reply-To: <1315287124-13972-2-git-send-email-tanmay.upadhyay@einfochips.com>
From: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
Date: Tue, 6 Sep 2011 11:02:04 +0530
> Commit a6b7a407865aab9f849dd99a71072b7cd1175116 removed
> linux/interrupt.h from netdevice.h. This fixes below build failure
>
> drivers/net/pxa168_eth.c: In function 'pxa168_eth_collect_events':
> drivers/net/pxa168_eth.c:866: error: 'IRQ_NONE' undeclared (first use in this function)
> drivers/net/pxa168_eth.c:866: error: (Each undeclared identifier is reported only once
> drivers/net/pxa168_eth.c:866: error: for each function it appears in.)
> drivers/net/pxa168_eth.c: At top level:
> drivers/net/pxa168_eth.c:913: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'pxa168_eth_int_handler'
> drivers/net/pxa168_eth.c: In function 'pxa168_eth_open':
> drivers/net/pxa168_eth.c:1133: error: implicit declaration of function 'request_irq'
> drivers/net/pxa168_eth.c:1133: error: 'pxa168_eth_int_handler' undeclared (first use in this function)
> drivers/net/pxa168_eth.c:1134: error: 'IRQF_DISABLED' undeclared (first use in this function)
> drivers/net/pxa168_eth.c:1160: error: implicit declaration of function 'free_irq'
>
> Signed-off-by: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
Applied, thanks.
prev parent reply other threads:[~2011-09-20 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 5:32 net: pxa168: Fix build errors by including interrupt.h Tanmay Upadhyay
2011-09-06 5:32 ` [PATCH] " Tanmay Upadhyay
2011-09-20 19:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920.154740.1212490857319716408.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=markb@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=prakity@marvell.com \
--cc=ssanap@marvell.com \
--cc=tanmay.upadhyay@einfochips.com \
--cc=zgao6@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).