* net: pxa168: Fix build errors by including interrupt.h
@ 2011-09-06 5:32 Tanmay Upadhyay
2011-09-06 5:32 ` [PATCH] " Tanmay Upadhyay
0 siblings, 1 reply; 3+ messages in thread
From: Tanmay Upadhyay @ 2011-09-06 5:32 UTC (permalink / raw)
To: ssanap, zgao6, prakity, markb; +Cc: netdev
I saw a recent patch that moves pxa168_eth.c to ethernet/marvell.
I still hope my patch is useful as I didn't any patch fixing these
build errors. Please ignore if it's already fixed somewhere.
Thanks,
Tanmay
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] net: pxa168: Fix build errors by including interrupt.h
2011-09-06 5:32 net: pxa168: Fix build errors by including interrupt.h Tanmay Upadhyay
@ 2011-09-06 5:32 ` Tanmay Upadhyay
2011-09-20 19:47 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Tanmay Upadhyay @ 2011-09-06 5:32 UTC (permalink / raw)
To: ssanap, zgao6, prakity, markb; +Cc: netdev, Tanmay Upadhyay
Commit a6b7a407865aab9f849dd99a71072b7cd1175116 removed
linux/interrupt.h from netdevice.h. This fixes below build failure
drivers/net/pxa168_eth.c: In function 'pxa168_eth_collect_events':
drivers/net/pxa168_eth.c:866: error: 'IRQ_NONE' undeclared (first use in this function)
drivers/net/pxa168_eth.c:866: error: (Each undeclared identifier is reported only once
drivers/net/pxa168_eth.c:866: error: for each function it appears in.)
drivers/net/pxa168_eth.c: At top level:
drivers/net/pxa168_eth.c:913: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'pxa168_eth_int_handler'
drivers/net/pxa168_eth.c: In function 'pxa168_eth_open':
drivers/net/pxa168_eth.c:1133: error: implicit declaration of function 'request_irq'
drivers/net/pxa168_eth.c:1133: error: 'pxa168_eth_int_handler' undeclared (first use in this function)
drivers/net/pxa168_eth.c:1134: error: 'IRQF_DISABLED' undeclared (first use in this function)
drivers/net/pxa168_eth.c:1160: error: implicit declaration of function 'free_irq'
Signed-off-by: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
---
drivers/net/pxa168_eth.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/pxa168_eth.c b/drivers/net/pxa168_eth.c
index 1a3033d..d17d062 100644
--- a/drivers/net/pxa168_eth.c
+++ b/drivers/net/pxa168_eth.c
@@ -40,6 +40,7 @@
#include <linux/clk.h>
#include <linux/phy.h>
#include <linux/io.h>
+#include <linux/interrupt.h>
#include <linux/types.h>
#include <asm/pgtable.h>
#include <asm/system.h>
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: pxa168: Fix build errors by including interrupt.h
2011-09-06 5:32 ` [PATCH] " Tanmay Upadhyay
@ 2011-09-20 19:47 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-09-20 19:47 UTC (permalink / raw)
To: tanmay.upadhyay; +Cc: ssanap, zgao6, prakity, markb, netdev
From: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
Date: Tue, 6 Sep 2011 11:02:04 +0530
> Commit a6b7a407865aab9f849dd99a71072b7cd1175116 removed
> linux/interrupt.h from netdevice.h. This fixes below build failure
>
> drivers/net/pxa168_eth.c: In function 'pxa168_eth_collect_events':
> drivers/net/pxa168_eth.c:866: error: 'IRQ_NONE' undeclared (first use in this function)
> drivers/net/pxa168_eth.c:866: error: (Each undeclared identifier is reported only once
> drivers/net/pxa168_eth.c:866: error: for each function it appears in.)
> drivers/net/pxa168_eth.c: At top level:
> drivers/net/pxa168_eth.c:913: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'pxa168_eth_int_handler'
> drivers/net/pxa168_eth.c: In function 'pxa168_eth_open':
> drivers/net/pxa168_eth.c:1133: error: implicit declaration of function 'request_irq'
> drivers/net/pxa168_eth.c:1133: error: 'pxa168_eth_int_handler' undeclared (first use in this function)
> drivers/net/pxa168_eth.c:1134: error: 'IRQF_DISABLED' undeclared (first use in this function)
> drivers/net/pxa168_eth.c:1160: error: implicit declaration of function 'free_irq'
>
> Signed-off-by: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-20 19:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-06 5:32 net: pxa168: Fix build errors by including interrupt.h Tanmay Upadhyay
2011-09-06 5:32 ` [PATCH] " Tanmay Upadhyay
2011-09-20 19:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).