From: "Matt Carlson" <mcarlson@broadcom.com>
To: "Kasper Pedersen" <kernel@kasperkp.dk>
Cc: "Matthew Carlson" <mcarlson@broadcom.com>,
"Michael Chan" <mchan@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tg3: fix VLAN tagging regression
Date: Tue, 20 Sep 2011 14:09:29 -0700 [thread overview]
Message-ID: <20110920210929.GA9652@mcarlson.broadcom.com> (raw)
In-Reply-To: <4E78FC38.7040903@kasperkp.dk>
On Tue, Sep 20, 2011 at 01:48:56PM -0700, Kasper Pedersen wrote:
> commit 92cd3a17ce9c719abb4c28dee3438e0c641f8de4
> tg3: Simplify tx bd assignments
>
> broke VLAN tagging on outbound packets.
> It ifdef'ed BCM_KERNEL_SUPPORTS_8021Q, but this
> is not set anywhere. So vlan never gets set, and
> all packets are sent with vlan=0.
>
> Change to use the CONFIG_VLAN_xxx defines instead.
> Tested on BCM5721 rev 11.
>
> Signed-off-by: Kasper Pedersen <kernel@kasperkp.dk>
Yes. This is correct.
Acked-by: Matt Carlson <mcarlson@broadcom.com>
> ---
> drivers/net/tg3.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index dc3fbf6..a00d21b 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -6234,7 +6234,7 @@ static netdev_tx_t tg3_start_xmit(struct sk_buff *skb, struct net_device *dev)
> }
> }
>
> -#ifdef BCM_KERNEL_SUPPORTS_8021Q
> +#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
> if (vlan_tx_tag_present(skb)) {
> base_flags |= TXD_FLAG_VLAN;
> vlan = vlan_tx_tag_get(skb);
>
>
next prev parent reply other threads:[~2011-09-20 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 20:48 [PATCH] tg3: fix VLAN tagging regression Kasper Pedersen
2011-09-20 21:09 ` Matt Carlson [this message]
2011-09-20 21:27 ` Jesse Gross
2011-09-20 21:57 ` Kasper Pedersen
2011-09-20 22:08 ` Eric Dumazet
2011-09-20 22:11 ` Eric Dumazet
2011-09-20 22:41 ` [PATCH v2] " Kasper Pedersen
2011-09-21 6:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920210929.GA9652@mcarlson.broadcom.com \
--to=mcarlson@broadcom.com \
--cc=kernel@kasperkp.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).