From: Wolfram Sang <w.sang@pengutronix.de>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: "Shawn Guo" <shawn.guo@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
patches@linaro.org, netdev@vger.kernel.org,
"Troy Kisky" <troy.kisky@boundarydevices.com>,
"Francois Romieu" <romieu@fr.zoreil.com>,
linux-arm-kernel@lists.infradead.org,
"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: Re: [PATCH v2 1/3] net/fec: change phy-reset-gpio request warning to debug message
Date: Wed, 21 Sep 2011 14:59:05 +0200 [thread overview]
Message-ID: <20110921125905.GI1966@pengutronix.de> (raw)
In-Reply-To: <20110921124423.GI28907@S2100-06.ap.freescale.net>
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
> > I agree that keeping it int is way better. But why not add it now to
> > keep things proper and tested? If this patch gets accepted as it is and
> > later someone else will add error checking to the caller, your platform
> > will lose FEC support as a regression.
> >
> Again, fec_reset_phy() failure is not a show-stopper. We might not
> want to make the probe fail because of that.
That would be an argument to make the function returning void?
Well, I still think something like
/* No phy reset configured */
if (phy_reset == -ENODEV)
return 0;
might be cleaner, yet I don't have the setup to test such an approach.
So, I'll be quiet now and hope for no problems.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-09-21 12:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 11:10 [PATCH v2 0/3] add fec support for imx6q Shawn Guo
2011-09-21 11:10 ` [PATCH v2 1/3] net/fec: change phy-reset-gpio request warning to debug message Shawn Guo
2011-09-21 11:25 ` Wolfram Sang
2011-09-21 12:03 ` Shawn Guo
2011-09-21 12:11 ` Wolfram Sang
2011-09-21 12:44 ` Shawn Guo
2011-09-21 12:59 ` Wolfram Sang [this message]
2011-09-21 13:18 ` Shawn Guo
2011-09-21 11:10 ` [PATCH v2 2/3] net/fec: fix fec1 check in fec_enet_mii_init() Shawn Guo
2011-09-21 11:10 ` [PATCH v2 3/3] net/fec: add imx6q enet support Shawn Guo
2011-09-21 11:07 ` Fabio Estevam
2011-09-21 11:28 ` Shawn Guo
2011-09-21 11:32 ` Wolfram Sang
2011-09-21 11:58 ` Shawn Guo
2011-09-21 12:26 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921125905.GI1966@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=LW@KARO-electronics.de \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=patches@linaro.org \
--cc=romieu@fr.zoreil.com \
--cc=shawn.guo@freescale.com \
--cc=shawn.guo@linaro.org \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).