From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: jesse.brandeburg@intel.com, netdev@vger.kernel.org, gospo@redhat.com
Subject: Re: [net-next 01/02] ixgb: eliminate checkstack warnings
Date: Fri, 23 Sep 2011 13:56:12 -0400 (EDT) [thread overview]
Message-ID: <20110923.135612.1546317832418041651.davem@davemloft.net> (raw)
In-Reply-To: <1316779890-32436-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 23 Sep 2011 05:11:29 -0700
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> Really trivial fix, use kmalloc/kfree instead of stack space.
> use static const instead of const to further reduce stack usage.
>
> V2: reflect changes suggested by Joe Perches
>
> before:
> [jbrandeb@jbrandeb-mobl2 linux-2.6]$ make checkstack|grep '\[ixgb\]'
> 0x00000fc1 ixgb_set_multi [ixgb]: 768
> 0x00001031 ixgb_set_multi [ixgb]: 768
> 0x000010f2 ixgb_set_multi [ixgb]: 768
> 0x061c ixgb_check_options [ixgb]: 448
> 0x09c3 ixgb_check_options [ixgb]: 448
> 0x0000649e ixgb_set_ringparam [ixgb]: 192
> 0x0000130d ixgb_xmit_frame [ixgb]: 184
> 0x000019e0 ixgb_xmit_frame [ixgb]: 184
> 0x00002267 ixgb_clean [ixgb]: 152
> 0x00002673 ixgb_clean [ixgb]: 152
>
> after:
> 0x000064ee ixgb_set_ringparam [ixgb]: 192
> 0x0000135d ixgb_xmit_frame [ixgb]: 184
> 0x00001a30 ixgb_xmit_frame [ixgb]: 184
> 0x000022b7 ixgb_clean [ixgb]: 152
> 0x000026c3 ixgb_clean [ixgb]: 152
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Tested-by: Aaron Brown <aaron.f.brown@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2011-09-23 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 12:11 [net-next 01/02] ixgb: eliminate checkstack warnings Jeff Kirsher
2011-09-23 12:11 ` [net-next 02/02] ixgb: finish conversion to ndo_fix_features Jeff Kirsher
2011-09-23 17:56 ` David Miller
2011-09-23 17:56 ` David Miller [this message]
2011-09-23 17:59 ` [net-next 01/02] ixgb: eliminate checkstack warnings Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110923.135612.1546317832418041651.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).