From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: "Rose, Gregory V" <gregory.v.rose@intel.com>,
Ian Campbell <ijc@hellion.org.uk>,
"davem@davemloft.net" <davem@davemloft.net>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [net-next 1/8] pci: Add flag indicating device has been assigned by KVM
Date: Fri, 23 Sep 2011 12:43:26 -0400 [thread overview]
Message-ID: <20110923164326.GA23363@phenom.oracle.com> (raw)
In-Reply-To: <1316792710.2182.124.camel@jtkirshe-mobl>
On Fri, Sep 23, 2011 at 08:45:09AM -0700, Jeff Kirsher wrote:
> On Fri, 2011-09-23 at 08:11 -0700, Rose, Gregory V wrote:
> > > -----Original Message-----
> > > From: Ian Campbell [mailto:ijc@hellion.org.uk]
> > > Sent: Friday, September 23, 2011 8:04 AM
> > > To: Rose, Gregory V
> > > Cc: Kirsher, Jeffrey T; davem@davemloft.net; konrad.wilk@oracle.com; Jesse
> > > Barnes; netdev@vger.kernel.org; gospo@redhat.com; linux-
> > > pci@vger.kernel.org
> > > Subject: RE: [net-next 1/8] pci: Add flag indicating device has been
> > > assigned by KVM
> > >
> > > On Fri, 2011-09-23 at 07:41 -0700, Rose, Gregory V wrote:
> > > > > -----Original Message-----
> > > > > From: Ian Campbell [mailto:ijc@hellion.org.uk]
> > > > > Sent: Friday, September 23, 2011 12:28 AM
> > > > > To: Kirsher, Jeffrey T
> > > > > Cc: davem@davemloft.net; konrad.wilk@oracle.com; Jesse Barnes; Rose,
> > > > > Gregory V; netdev@vger.kernel.org; gospo@redhat.com; linux-
> > > > > pci@vger.kernel.org
> > > > > Subject: Re: [net-next 1/8] pci: Add flag indicating device has been
> > > > > assigned by KVM
> > > > >
> > > > > I suppose by that measure the comment could be less KVM specific:
> > > > > > + /* Provide indication device is assigned by KVM */
> > > > > > + PCI_DEV_FLAGS_ASSIGNED = (__force pci_dev_flags_t) 4,
> > > >
> > > > We can resubmit with a more generic comment, maybe this:
> > > >
> > > > /* Provide indication device is assigned by a Virtual Machine Manager */
> > >
> > > Sounds good to me.
> >
> > Dave, Jeff,
> >
> > Should I resubmit the patch or would it be more convenient to post a follow on patch that fixes up the comment? Either way is fine by me.
> >
> > - Greg
> >
>
> let's fix up the patch in my tree and add Jesse Barnes's ACK at the same
> time.
Were are the patches now? I am kind of curious to see the changes to the xen pciback.
next prev parent reply other threads:[~2011-09-23 16:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 10:12 [net-next 0/8][pull request] Intel Wired LAN Driver Update Jeff Kirsher
2011-09-21 10:12 ` [net-next 1/8] pci: Add flag indicating device has been assigned by KVM Jeff Kirsher
2011-09-23 4:16 ` Jeff Kirsher
2011-09-23 5:20 ` Jesse Barnes
[not found] ` <20110923104957.2f76d1a4@jbarnes-x220>
2011-09-23 5:23 ` Jeff Kirsher
2011-09-23 7:27 ` Ian Campbell
2011-09-23 14:41 ` Rose, Gregory V
2011-09-23 15:03 ` Ian Campbell
2011-09-23 15:11 ` Rose, Gregory V
2011-09-23 15:45 ` Jeff Kirsher
2011-09-23 16:43 ` Konrad Rzeszutek Wilk [this message]
2011-09-23 17:04 ` Rose, Gregory V
2011-09-23 18:00 ` Konrad Rzeszutek Wilk
2011-09-23 18:24 ` Rose, Gregory V
2011-09-23 19:05 ` Konrad Rzeszutek Wilk
2011-09-23 19:20 ` Rose, Gregory V
2011-09-24 4:41 ` Jeff Kirsher
2011-09-26 16:25 ` [net-next 1/8] pci: Add flag indicating device has been assigned by KVM [and Xen] Konrad Rzeszutek Wilk
2011-09-26 16:31 ` Rose, Gregory V
2011-09-26 16:42 ` Konrad Rzeszutek Wilk
2011-09-26 17:01 ` Rose, Gregory V
2011-09-21 10:12 ` [net-next 2/8] ixgbe: Reconfigure SR-IOV Init Jeff Kirsher
2011-09-21 10:12 ` [net-next 3/8] ixgbe: DCB, do not call set_state() from IEEE mode Jeff Kirsher
2011-09-21 10:12 ` [net-next 4/8] ixgbe: cleanup X540 interrupt enablement Jeff Kirsher
2011-09-21 10:12 ` [net-next 5/8] ixgbe: dcb, set priority to traffic class mappings Jeff Kirsher
2011-09-21 10:12 ` [net-next 6/8] ixgbe: avoid HW lockup when adapter is reset with Tx work pending Jeff Kirsher
2011-09-21 10:12 ` [net-next 7/8] ixgbe: add WOL support for X540 Jeff Kirsher
2011-09-21 10:12 ` [net-next 8/8] ixgbe: remove global reset to the MAC Jeff Kirsher
2011-09-21 19:13 ` [net-next 0/8][pull request] Intel Wired LAN Driver Update David Miller
2011-09-21 19:58 ` Rose, Gregory V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110923164326.GA23363@phenom.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=ijc@hellion.org.uk \
--cc=jbarnes@virtuousgeek.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).