From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Xiong <bottomofstack@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: Why not refresh ipv6 local link address of a bridge when a new interface added to the bridge?
Date: Mon, 26 Sep 2011 08:51:17 -0700 [thread overview]
Message-ID: <20110926085117.1a749151@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <CA+UXGK3yQzUuZwHWooxd91G77ACvYzwTQUOoDdVc-=CCEv4POQ@mail.gmail.com>
On Tue, 20 Sep 2011 10:39:31 +0800
Eric Xiong <bottomofstack@gmail.com> wrote:
> Hi all:
> Sorry for disturb! when adding a interface to bridge, maybe the bridge
> mac address will be changed. the bridge code don't invoke
> call_netdevice_notifiers to notify ipv6 code to refresh local link
> address. I don't know why. Thanks for your help!
>
> BRs.
This change went in for v3.1
Bridge: Always send NETDEV_CHANGEADDR up on br MAC change.
This ensures the neighbor entries associated with the bridge
dev are flushed, also invalidating the associated cached L2 headers.
This means we br_add_if/br_del_if ports to implement hand-over and
not wind up with bridge packets going out with stale MAC.
This means we can also change MAC of port device and also not wind
up with bridge packets going out with stale MAC.
This builds on Stephen Hemminger's patch, also handling the br_del_if
case and the port MAC change case.
Cc: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Andrei Warkentin <andreiw@motorola.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2011-09-26 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+UXGK1Ej4DeS5-=FO0ejMCGjWfptxxxRibhMi2-duE9Cx2D_g@mail.gmail.com>
[not found] ` <CA+UXGK1XAgCxYUoOAP6yQSGhzDB-3p3oDqOoOc_e=rTT3DPx7Q@mail.gmail.com>
2011-09-20 2:39 ` Why not refresh ipv6 local link address of a bridge when a new interface added to the bridge? Eric Xiong
2011-09-26 15:51 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926085117.1a749151@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=bottomofstack@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).