From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: Why not refresh ipv6 local link address of a bridge when a new interface added to the bridge? Date: Mon, 26 Sep 2011 08:51:17 -0700 Message-ID: <20110926085117.1a749151@nehalam.linuxnetplumber.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Eric Xiong Return-path: Received: from mail.vyatta.com ([76.74.103.46]:40674 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257Ab1IZPv1 (ORCPT ); Mon, 26 Sep 2011 11:51:27 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 20 Sep 2011 10:39:31 +0800 Eric Xiong wrote: > Hi all: > Sorry for disturb! when adding a interface to bridge, maybe the bridge > mac address will be changed. the bridge code don't invoke > call_netdevice_notifiers to notify ipv6 code to refresh local link > address. I don't know why. Thanks for your help! > > BRs. This change went in for v3.1 Bridge: Always send NETDEV_CHANGEADDR up on br MAC change. This ensures the neighbor entries associated with the bridge dev are flushed, also invalidating the associated cached L2 headers. This means we br_add_if/br_del_if ports to implement hand-over and not wind up with bridge packets going out with stale MAC. This means we can also change MAC of port device and also not wind up with bridge packets going out with stale MAC. This builds on Stephen Hemminger's patch, also handling the br_del_if case and the port MAC change case. Cc: Stephen Hemminger Signed-off-by: Andrei Warkentin Acked-by: Stephen Hemminger Signed-off-by: David S. Miller